Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-14737: [C++][Dataset] Support URI-decoding partition keys #11858

Closed
wants to merge 1 commit into from
Closed

ARROW-14737: [C++][Dataset] Support URI-decoding partition keys #11858

wants to merge 1 commit into from

Conversation

Jedi18
Copy link
Contributor

@Jedi18 Jedi18 commented Dec 4, 2021 •
edited
Loading

Support URI decoding of key in hive partitioning.

@github-actions
Copy link

github-actions bot commented Dec 4, 2021

https://issues.apache.org/jira/browse/ARROW-14737

@Jedi18 Jedi18 force-pushed the support_uri_decode_partition_key branch 2 times, most recently from 7ddd5b3 to 2de1569 Compare December 5, 2021 13:54
@Jedi18 Jedi18 marked this pull request as ready for review December 5, 2021 13:57
@Jedi18 Jedi18 force-pushed the support_uri_decode_partition_key branch 6 times, most recently from f044b75 to 3467ea0 Compare December 6, 2021 06:12
@Jedi18 Jedi18 force-pushed the support_uri_decode_partition_key branch 3 times, most recently from 32d0703 to 67cdf3c Compare December 11, 2021 10:54
lidavidm
lidavidm approved these changes Dec 13, 2021
View reviewed changes
Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. This looks good to me.

cpp/src/arrow/dataset/partition.cc Outdated Show resolved Hide resolved
@Jedi18
Support uri decoding the partition keys and add tests in cpp, python and
d22039d 
r tests for hive partitioning with enccoded keys
@Jedi18 Jedi18 force-pushed the support_uri_decode_partition_key branch from 67cdf3c to d22039d Compare December 13, 2021 13:27
@lidavidm lidavidm closed this in 11be9c5 Dec 13, 2021
@lidavidm
Copy link
Member

Thank you @Jedi18!

@ursabot
Copy link

ursabot commented Dec 13, 2021 •
edited
Loading

Benchmark runs are scheduled for baseline = dee4ba3 and contender = 11be9c5. 11be9c5 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.62% ⬆️0.0%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@zijie0 zijie0 mentioned this pull request Feb 24, 2022
Closed
@asfimport asfimport mentioned this pull request Dec 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pitrou pitrou pitrou left review comments

@houqp houqp houqp left review comments

@lidavidm lidavidm lidavidm approved these changes

Assignees
No one assigned
Labels
Component: C++ Component: Python Component: R
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Jedi18 @lidavidm @ursabot @houqp @pitrou