Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-8340: [Documentation] Remove the old Sphinx pin #11878

Closed
wants to merge 7 commits into from

Conversation

AlenkaF
Copy link
Member

@AlenkaF AlenkaF commented Dec 7, 2021

Remove the pin for Sphinx in requirements.txt. The documentation builds successfully with Sphinx version 4.3.1.

@github-actions
Copy link

github-actions bot commented Dec 7, 2021

@github-actions
Copy link

github-actions bot commented Dec 7, 2021

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@kszucs
Copy link
Member

kszucs commented Dec 7, 2021

@AlenkaF could you please reference this requirements file from https://github.com/apache/arrow/blob/master/ci/docker/linux-apt-docs.dockerfile#L77 ?

Need to add to .dockerignore before using COPY in the dockerfile.

@AlenkaF
Copy link
Member Author

AlenkaF commented Dec 7, 2021

@AlenkaF could you please reference this requirements file from https://github.com/apache/arrow/blob/master/ci/docker/linux-apt-docs.dockerfile#L77 ?

Happy to do it! (Change the requirements to be like in the dockerfile, if I understand correctly?)

@kszucs
Copy link
Member

kszucs commented Dec 7, 2021

And then install the dependencies in the docker image using the docs/requirements.txt file.

docs/requirements.txt Outdated Show resolved Hide resolved
docs/requirements.txt Show resolved Hide resolved
@jorisvandenbossche jorisvandenbossche changed the title ARROW-8340: [Documentation] Sphinx documentation does not build with just-released Sphinx 3.0.0 ARROW-8340: [Documentation] Remove the old Sphinx pin Dec 8, 2021
Copy link
Member

@kszucs kszucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Alenka!

@kszucs kszucs closed this in 3f7f245 Dec 13, 2021
@AlenkaF AlenkaF deleted the ARROW-8340 branch December 13, 2021 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants