Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-15056: [C++] Speed up GcsFileSystem tests #11933

Closed
wants to merge 1 commit into from
Closed

ARROW-15056: [C++] Speed up GcsFileSystem tests #11933

wants to merge 1 commit into from

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Dec 11, 2021

This reduces the running time from about 60s to about 10s.

Before:

86/86 Test #50: arrow-gcsfs-test ..........................   Passed   60.00 sec

After:

71/86 Test #50: arrow-gcsfs-test ..........................   Passed    9.62 sec

@github-actions
Copy link

@coryan coryan marked this pull request as ready for review December 11, 2021 17:33
@coryan
Copy link
Contributor Author

coryan commented Dec 11, 2021

The failures seem unrelated. Please take a look.

@pitrou
Copy link
Member

pitrou commented Dec 13, 2021

Wow, that's nifty, thank you!

@pitrou pitrou closed this in 575e2ff Dec 13, 2021
@ursabot
Copy link

ursabot commented Dec 13, 2021

Benchmark runs are scheduled for baseline = 11be9c5 and contender = 575e2ff. 575e2ff is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.45% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.13% ⬆️0.09%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@coryan coryan deleted the ARROW-15056-gcsfs-speedup-tests branch December 14, 2021 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants