-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-15112: [Integration][C++][Java] Implement Flight SQL integration tests #11989
Closed
rafael-telles
wants to merge
8
commits into
apache:flight-sql
from
rafael-telles:flight-sql-integration-tests-2
Closed
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
9b55daa
Separate Flight integration tests into new modules
rafael-telles 0121012
Create integration tests for Flight SQL Java and C++
rafael-telles 163fa77
Implement validation for prepared statement's parameter binding on in…
rafael-telles 4d384ab
Skip Rust and Go from Flight SQL integration test scenario
rafael-telles f6bbf6c
Fix formatting issues on C++ integration tests
rafael-telles 97fe3ce
Fix TestFlightSqlServer#TestCommandGetSqlInfoNoInfo failure on CI
rafael-telles f273156
nit: Extract expected results for update statements as constants (C++…
rafael-telles 4b21e94
nit: Use quotes on arrow includes on test_integration.cc
rafael-telles File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
# Licensed to the Apache Software Foundation (ASF) under one | ||
# or more contributor license agreements. See the NOTICE file | ||
# distributed with this work for additional information | ||
# regarding copyright ownership. The ASF licenses this file | ||
# to you under the Apache License, Version 2.0 (the | ||
# "License"); you may not use this file except in compliance | ||
# with the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
|
||
add_custom_target(arrow_flight_integration_tests) | ||
|
||
if(ARROW_FLIGHT_TEST_LINKAGE STREQUAL "static") | ||
set(ARROW_FLIGHT_TEST_LINK_LIBS | ||
arrow_flight_static | ||
arrow_flight_testing_static | ||
arrow_flight_sql_static | ||
${ARROW_FLIGHT_STATIC_LINK_LIBS} | ||
${ARROW_TEST_LINK_LIBS}) | ||
else() | ||
set(ARROW_FLIGHT_TEST_LINK_LIBS | ||
arrow_flight_shared | ||
arrow_flight_testing_shared | ||
arrow_flight_sql_shared | ||
${ARROW_TEST_LINK_LIBS} | ||
${ARROW_FLIGHT_SQL_TEST_LINK_LIBS}) | ||
endif() | ||
|
||
add_executable(flight-test-integration-server test_integration_server.cc | ||
test_integration.cc) | ||
target_link_libraries(flight-test-integration-server ${ARROW_FLIGHT_TEST_LINK_LIBS} | ||
${GFLAGS_LIBRARIES} GTest::gtest) | ||
|
||
add_executable(flight-test-integration-client test_integration_client.cc | ||
test_integration.cc) | ||
target_link_libraries(flight-test-integration-client ${ARROW_FLIGHT_TEST_LINK_LIBS} | ||
${GFLAGS_LIBRARIES} GTest::gtest) | ||
|
||
add_dependencies(arrow-integration flight-test-integration-client | ||
flight-test-integration-server) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the target necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was already there on arrow/flight/CMakeLists.txt before moving to the new directory