-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-15601: [Docs][Release] Update post release script to move stable docs + keep dev docs #12355
Conversation
…e docs + keep dev docs
One thing I just realized is that the "move current stable to previous version" logic only needs to happen for a major release, and not when doing a bug-fix release (eg 7.0.1). So that logic should maybe be behind a flag (eg based on whether the second "previous_version" parameter was specified?) |
How about checking the minor and patch version in the first argument? case "${version}" in
*.0.0)
is_major_release=yes
;;
*)
is_major_release=no
;;
esac If we need to change the number of arguments depending on context, a human error will occur. |
@kou thanks for the suggestion! |
git add docs | ||
git commit -m "[Website] Update documentations for ${version}" | ||
git clean -d -f -x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not strictly "needed" for the creating the correct PR, but the script does leave a bunch of ignored files after running it locally (eg we don't commit the .doctrees files), and including this ensures it cleans up after itself. I could also limit it to the /docs/ directory (or remove it altogether)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see.
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Sorry for the delay here, this should be ready now I think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Benchmark runs are scheduled for baseline = c4c5c03 and contender = 8963755. 8963755 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
…e docs + keep dev docs This updates the post-release script for the docs with: - keep the `/docs/dev` docs - move the current stable docs (without all versioned + dev docs subdirectories) to a new versioned subdirectory Closes apache#12355 from jorisvandenbossche/ARROW-15601 Lead-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com> Co-authored-by: Sutou Kouhei <kou@cozmixng.org> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
This updates the post-release script for the docs with:
/docs/dev
docs