Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-15626: [GLib] Fix a bug that GArrowGIOInputStream may not read enough data #12380

Closed
wants to merge 5 commits into from

Conversation

rsaccoccio
Copy link
Contributor

If GIOInputStream is used with a file descriptor that can return short reads, it will too. This breaks the assumption by callers that the Read() will return all that it asked for.

@github-actions
Copy link

github-actions bot commented Feb 9, 2022

@github-actions
Copy link

github-actions bot commented Feb 9, 2022

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@kou kou changed the title ARROW-15626: GIOInputStream can return short reads ARROW-15626: [GLib] GIOInputStream can return short reads Feb 9, 2022
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

c_glib/arrow-glib/input-stream.cpp Outdated Show resolved Hide resolved
c_glib/arrow-glib/input-stream.cpp Outdated Show resolved Hide resolved
@kou kou changed the title ARROW-15626: [GLib] GIOInputStream can return short reads ARROW-15626: [GLib] Fix a bug that GArrowGIOInputStream may not read enough data Apr 20, 2022
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou closed this in 0650241 Apr 20, 2022
@ursabot
Copy link

ursabot commented Apr 21, 2022

Benchmark runs are scheduled for baseline = 4354ad7 and contender = 0650241. 0650241 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.46% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.38% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.3% ⬆️0.04%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/547| 06502414 ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/534| 06502414 test-mac-arm>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/533| 06502414 ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/544| 06502414 ursa-thinkcentre-m75q>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/546| 4354ad74 ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/533| 4354ad74 test-mac-arm>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/532| 4354ad74 ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/543| 4354ad74 ursa-thinkcentre-m75q>
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants