Skip to content

ARROW-14824 [R] Implement bindings for lubridate::epiyear()#12545

Closed
dragosmg wants to merge 2 commits intoapache:masterfrom
dragosmg:lubridate_epiyear
Closed

ARROW-14824 [R] Implement bindings for lubridate::epiyear()#12545
dragosmg wants to merge 2 commits intoapache:masterfrom
dragosmg:lubridate_epiyear

Conversation

@dragosmg
Copy link
Contributor

@dragosmg dragosmg commented Mar 2, 2022

No description provided.

@dragosmg dragosmg marked this pull request as ready for review March 2, 2022 12:15
@github-actions
Copy link

github-actions bot commented Mar 2, 2022

https://issues.apache.org/jira/browse/ARROW-14824

thisisnic
thisisnic reviewed Mar 2, 2022
View reviewed changes
Copy link
Member

@thisisnic thisisnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's missing the test "extract epiyear from date", but once that's done it's good to go!

@dragosmg
Copy link
Contributor Author

dragosmg commented Mar 2, 2022

I've added the epiyear(date) test. Ready for another look. Thanks @thisisnic

thisisnic
thisisnic approved these changes Mar 2, 2022
View reviewed changes
Copy link
Member

@thisisnic thisisnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thisisnic thisisnic closed this in da058a7 Mar 2, 2022
@ursabot
Copy link

ursabot commented Mar 2, 2022 •
edited
Loading

Benchmark runs are scheduled for baseline = d9a5c16 and contender = da058a7. da058a7 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.17% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.36% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.51% ⬆️0.04%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@dragosmg dragosmg deleted the lubridate_epiyear branch March 3, 2022 18:15
@asfimport asfimport mentioned this pull request Mar 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thisisnic thisisnic thisisnic approved these changes

Assignees

No one assigned

Labels

Component: R

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dragosmg @ursabot @thisisnic