Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [Python] Change a test file name for better bazel support #12643

Closed
wants to merge 1 commit into from
Closed

MINOR: [Python] Change a test file name for better bazel support #12643

wants to merge 1 commit into from

Conversation

iampat
Copy link
Contributor

@iampat iampat commented Mar 16, 2022

Bazel pep_deps rule can not handle files names with = in the name [1]. Unfortunately, there is no way to fix this issue in Bazel.

[1] bazelbuild/bazel#374

Bazel pep_deps rule can not handle files names with `=` in the name [1]. Unfortuently there is no easy way to fix this issue in Bazel.

[1] bazelbuild/bazel#374
@pitrou pitrou changed the title MINOR: Change a test file names for better bazel support MINOR: [Python] Change a test file name for better bazel support Mar 16, 2022
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that seems fine to change this from our side, if that helps for bazel.

@ursabot
Copy link

ursabot commented Mar 17, 2022

Benchmark runs are scheduled for baseline = ecf8c75 and contender = 84879b9. 84879b9 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.29% ⬆️0.04%] test-mac-arm
[Failed ⬇️0.36% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.26% ⬆️0.04%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@iampat
Copy link
Contributor Author

iampat commented Mar 18, 2022

Thanks

@iampat iampat deleted the iampat/fix_bazel_pep_import branch March 18, 2022 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants