Skip to content

ARROW-15665: [C++] Fix error_is_null in strptime with invalid inputs #12732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rok wants to merge 1 commit into from
Closed

ARROW-15665: [C++] Fix error_is_null in strptime with invalid inputs #12732

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cpp/src/arrow/compute/kernels/scalar_string_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1841,14 +1841,14 @@ TYPED_TEST(TestBaseBinaryKernels, ExtractRegexInvalid) {

TYPED_TEST(TestStringKernels, Strptime) {
std::string input1 = R"(["5/1/2020", null, null, "12/13/1900", null])";
std::string input2 = R"(["5/1/2020", "12/13/1900"])";
std::string input2 = R"(["5-1-2020", "12/13/1900"])";
std::string input3 = R"(["5/1/2020", "AA/BB/CCCC"])";
std::string input4 = R"(["5/1/2020", "AA/BB/CCCC", "AA/BB/CCCC", "AA/BB/CCCC", null])";
std::string input5 = R"(["5/1/2020 %z", null, null, "12/13/1900 %z", null])";
std::string output1 = R"(["2020-05-01", null, null, "1900-12-13", null])";
std::string output4 = R"(["2020-01-05", null, null, null, null])";
std::string output2 = R"(["2020-05-01", "1900-12-13"])";
std::string output2 = R"([null, "1900-12-13"])";
std::string output3 = R"(["2020-05-01", null])";
std::string output4 = R"(["2020-01-05", null, null, null, null])";

StrptimeOptions options("%m/%d/%Y", TimeUnit::MICRO, /*error_is_null=*/true);
auto unit = timestamp(TimeUnit::MICRO);
Expand Down
1 change: 1 addition & 0 deletions cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1230,6 +1230,7 @@ struct Strptime {
if ((*self.parser)(s.data(), s.size(), self.unit, &result)) {
*out_data++ = result;
} else {
out_data++;
out_writer.Clear();
null_count++;
}
Expand Down