ARROW-16317: [CI][Dev] Do not use incremental ids on crossbow submit action branches

[raulcd]

The aim of this PR is to avoid a possible race condition when submitting crossbow builds. Currently when there is a race condition when submitting crossbow builds we can see the following type of error:

Failed to push updated references, potentially because of credential issues: ['refs/heads/actions-1883-github-wheel-windows-cp310-amd64', 'refs/tags/actions-1883-github-wheel-windows-cp310-amd64', 'refs/heads/actions-1883-github-wheel-windows-cp39-amd64', 'refs/tags/actions-1883-github-wheel-windows-cp39-amd64', 'refs/heads/actions-1883-github-wheel-windows-cp37-amd64', 'refs/tags/actions-1883-github-wheel-windows-cp37-amd64', 'refs/heads/actions-1883-github-wheel-windows-cp38-amd64', 'refs/tags/actions-1883-github-wheel-windows-cp38-amd64', 'refs/heads/actions-1883']
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/2195038965

The idea is to use a 10 characters hex from an uuid instead of an incremental id.

[raulcd]

@github-actions crossbow submit example-cpp-minimal-build-static

[github-actions]

https://issues.apache.org/jira/browse/ARROW-16317

[github-actions]

Revision: b47f16a

Submitted crossbow builds: ursacomputing/crossbow @ actions-2111

Task	Status
example-cpp-minimal-build-static

[raulcd]

It does not seem to be working yet, that's why I've marked it as draft again, I am investigating why the branch from the triggered action hasn't been created with the new naming convention.

[kszucs]

It does not seem to be working yet, that's why I've marked it as draft again, I am investigating why the branch from the triggered action hasn't been created with the new naming convention.

Thanks for working on this! Let me know when it's ready for review!

[raulcd]

@github-actions crossbow submit example-cpp-minimal-build-static

[github-actions]

Revision: 14e61415721a066c2baee1161d713c265a3c63cc

Submitted crossbow builds: ursacomputing/crossbow @ actions-2113

Task	Status
example-cpp-minimal-build-static

[raulcd]

@github-actions crossbow submit example-cpp-minimal-build-static

[github-actions]

Revision: ba2bd968ce4ce03474f4195dcf79dab5ed3e6cad

Submitted crossbow builds: ursacomputing/crossbow @ actions-2114

Task	Status
example-cpp-minimal-build-static

[raulcd]

@github-actions crossbow submit example-cpp-minimal-build-static

[github-actions]

Revision: 2bdeb667124c677be176e4e9b2fb3701f6f02b01

Submitted crossbow builds: ursacomputing/crossbow @ actions-2115

Task	Status
example-cpp-minimal-build-static

[raulcd]

ok, I have been doing some investigation and the bot comment workflow is checking out from master so it is not really picking up my changes on this PR:

  /usr/bin/git checkout --progress --force -B master refs/remotes/origin/master
  Reset branch 'master'
  branch 'master' set up to track 'origin/master'.

@kszucs have you worked around that in the past? do you know if there is a way I could test this workflow change from my PR branch?
Otherwise I'll keep investigating tomorrow I might try to tweak a forked repo to trigger a comment bot and archery

[raulcd]

This is the URL for the triggered action for the comment bot where the usage of the master branch can be seen: https://github.com/apache/arrow/runs/6495575450?check_suite_focus=true

[raulcd]

@github-actions crossbow submit example-cpp-minimal-build-static

[github-actions]

Revision: 0ed864177e83ce21ca63cea8f69d65baa9d4eebc

Submitted crossbow builds: ursacomputing/crossbow @ actions-2117

Task	Status
example-cpp-minimal-build-static

[raulcd]

@github-actions crossbow submit example-cpp-minimal-build-static

[github-actions]

Revision: 6a2ab6286d1ac7eef1d51b31649d961faa224c14

Submitted crossbow builds: ursacomputing/crossbow @ actions-2118

Task	Status
example-cpp-minimal-build-static

[raulcd]

Hi @kszucs, I think this is ready for review, it has been slightly tricky to validate so I am going to explain on the comment here.
There are two commits on this PR, one with the change of using the 10 digit hex as part of the action branch name and one to modify the comment bot in order to pick the PR changes on archery instead of always from master. This second commit will allow us to be able to test changes for the comment bot from the PR.

I have tested on my own fork by:

• Merging to my master branch the commit about the comment bot so it is able to checkout the PR instead of master as seen on the comment bot action triggered
• Creating a PR with the changes on the crossbow submit action on my own repo and validate the branch created on crossbow is the correct one

Please let me know your thoughts and if you would like me to split the two commits on two different issues as they are solving slightly different issues.

[raulcd]

Hi @kszucs I have removed the second commit that allowed us to test the comment bot changes checking out archery from the PR as discussed. The good thing is I know how I can test it in the future and we have been able to verify the change is successful from my fork tests.

[kszucs]

Thanks Raul!

[kszucs]

@raulcd we may want to set the hash based job id as default so we wouldn't need to fetch the references from crossbow at all. I regularly use archery crossbow submit --no-fetch ... because libgit2 isn't great with fetching.

[ursabot]

Benchmark runs are scheduled for baseline = 7f31c9d and contender = f136365. f136365 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.66% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.32% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] f1363657 ec2-t3-xlarge-us-east-2
[Failed] f1363657 test-mac-arm
[Failed] f1363657 ursa-i9-9960x
[Finished] f1363657 ursa-thinkcentre-m75q
[Finished] 7f31c9d2 ec2-t3-xlarge-us-east-2
[Failed] 7f31c9d2 test-mac-arm
[Failed] 7f31c9d2 ursa-i9-9960x
[Finished] 7f31c9d2 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java