-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-12626: [C++] Support toolchain xsimd, update toolchain version to version 8.1.0 #13244
Conversation
6db3a2e
to
d7d3101
Compare
@kou, is there convenient way to verify if this pr may break packaging and release in github UI? |
We can use |
@github-actions crossbow submit -g nightly-packaging -g nightly-release |
This comment was marked as outdated.
This comment was marked as outdated.
9af5ea8
to
4a006ad
Compare
@github-actions crossbow submit -g nightly-packaging -g nightly-release |
Revision: 4a006ad Submitted crossbow builds: ursacomputing/crossbow @ actions-8103008ca7 |
There are many xsimd related errors, @kou, will you comment perferred fixes? Thanks.
|
As I recall, the project was pinned to a bundled version that was a few weeks before 8.1 was released. Feel free to take control of this PR from me |
I'll push fixes later. Please wait for a while. |
4a006ad
to
902e81c
Compare
@github-actions crossbow submit conan-* conda-linux-gcc-* |
Revision: 902e81c Submitted crossbow builds: ursacomputing/crossbow @ actions-76b5b8c64b |
@github-actions crossbow submit conda-osx-* conda-win-* |
Revision: addd3ac Submitted crossbow builds: ursacomputing/crossbow @ actions-603614ae49 |
I've opened a pull request to update xsimd in vcpkg: microsoft/vcpkg#25030 |
@github-actions crossbow submit conan-* |
Revision: 309e42a Submitted crossbow builds: ursacomputing/crossbow @ actions-983084a5d3
|
|
@github-actions crossbow submit wheel-* |
Revision: d100b39 Submitted crossbow builds: ursacomputing/crossbow @ actions-9de9fb80c7 |
da2798f
to
160ec95
Compare
@github-actions crossbow submit wheel-* |
Revision: 160ec95 Submitted crossbow builds: ursacomputing/crossbow @ actions-082fa4d9b1 |
@github-actions crossbow java-jars |
@github-actions crossbow submit wheel-windows-cp38-amd64 |
Revision: 21b3427 Submitted crossbow builds: ursacomputing/crossbow @ actions-729a5ecccd
|
@github-actions crossbow submit wheel-windows-cp38-amd64 |
Revision: 083fdba Submitted crossbow builds: ursacomputing/crossbow @ actions-1fd3333176
|
@github-actions crossbow submit wheel-windows-cp38-amd64 |
Revision: 2c2cf17 Submitted crossbow builds: ursacomputing/crossbow @ actions-f57e2a50a4
|
@github-actions crossbow submit wheel-windows-cp38-amd64 |
Revision: 080fc8f Submitted crossbow builds: ursacomputing/crossbow @ actions-c871540910
|
@github-actions crossbow submit wheel-windows-cp38-amd64 |
Revision: be9daf2 Submitted crossbow builds: ursacomputing/crossbow @ actions-d8403e63aa
|
@github-actions crossbow submit wheel-windows-cp38-amd64 |
Revision: e5bf8ca Submitted crossbow builds: ursacomputing/crossbow @ actions-c62ae2d49f
|
@github-actions crossbow submit wheel-windows-cp38-amd64 |
Revision: 4edd5b0 Submitted crossbow builds: ursacomputing/crossbow @ actions-3056f2001d
|
@github-actions crossbow submit wheel-windows-* |
Revision: 4edd5b0 Submitted crossbow builds: ursacomputing/crossbow @ actions-aa101b6926
|
2h 51min vs 1h 🥳 🚀 |
This reverts commit cae313b.
if ! docker pull; then
docker build
fi
docker run This is ready to merge now. I'll merge this tomorrow. |
This also updates pinned vcpkg to use xsimd 8.1.0.
This also implements auto python-wheel-windows-vs2017 image update mechanism.
We have a problem of "docker build" on Windows. "docker build" doesn't reuse pulled
image as caches. "docker build" always rebuilds an image. This implements manual
reuse mechanism like the following:
But this doesn't work when ci/docker/python-wheel-windows-vs2017.dockerfile is updated
but pinned vcpkg revision isn't changed. In the case, "docker build" isn't run because
"docker pull" is succeeded.
To work this mechanism, this introduces "PYTHON_WHEEL_WINDOWS_IMAGE_REVISION".
We must bump it manually when we update ci/docker/python-wheel-windows-vs2017.dockerfile.
"PYTHON_WHEEL_WINDOWS_IMAGE_REVISION" is used in tag name. So "docker pull"
is failed with new "PYTHON_WHEEL_WINDOWS_IMAGE_REVISION" and then "docker build"
is used.