Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-17050: [CI] Use -y flag on mamba install to not ask for confirmation #13579

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

raulcd
Copy link
Member

@raulcd raulcd commented Jul 12, 2022

When locally building the conda-cpp-valgrind docker image I've realised we are prompting for confirmation:

#10 12.35 Confirm changes: [Y/n] 
#10 88.01  

We should use the -y flag when using mamba install:

  -y, --yes             Do not ask for confirmation.

With this change we are no longer seeing the Confirm changes message from mamba.

@raulcd
Copy link
Member Author

raulcd commented Jul 12, 2022

@github-actions crossbow submit conda

@raulcd
Copy link
Member Author

raulcd commented Jul 12, 2022

This did not fail because of how docker manages tty but I still think it's best to use the -y flag as expected on this case.

@github-actions
Copy link

Revision: c84f827

Submitted crossbow builds: ursacomputing/crossbow @ actions-f4e59c9c7f

Task Status
conda-clean Azure
conda-linux-gcc-py310-arm64 Azure
conda-linux-gcc-py310-cpu Azure
conda-linux-gcc-py310-cuda Azure
conda-linux-gcc-py310-ppc64le Azure
conda-linux-gcc-py37-arm64 Azure
conda-linux-gcc-py37-cpu-r40 Azure
conda-linux-gcc-py37-cpu-r41 Azure
conda-linux-gcc-py37-cuda Azure
conda-linux-gcc-py37-ppc64le Azure
conda-linux-gcc-py38-arm64 Azure
conda-linux-gcc-py38-cpu Azure
conda-linux-gcc-py38-cuda Azure
conda-linux-gcc-py38-ppc64le Azure
conda-linux-gcc-py39-arm64 Azure
conda-linux-gcc-py39-cpu Azure
conda-linux-gcc-py39-cuda Azure
conda-linux-gcc-py39-ppc64le Azure
conda-osx-arm64-clang-py310 Azure
conda-osx-arm64-clang-py38 Azure
conda-osx-arm64-clang-py39 Azure
conda-osx-clang-py310 Azure
conda-osx-clang-py37-r40 Azure
conda-osx-clang-py37-r41 Azure
conda-osx-clang-py38 Azure
conda-osx-clang-py39 Azure
conda-win-vs2017-py310 Azure
conda-win-vs2017-py37-r40 Azure
conda-win-vs2017-py37-r41 Azure
conda-win-vs2017-py38 Azure
conda-win-vs2017-py39 Azure
example-python-minimal-build-fedora-conda Github Actions
test-conda-cpp Github Actions
test-conda-cpp-valgrind Azure
test-conda-python-3.10 Github Actions
test-conda-python-3.7 Github Actions
test-conda-python-3.7-hdfs-2.9.2 Github Actions
test-conda-python-3.7-hdfs-3.2.1 Github Actions
test-conda-python-3.7-kartothek-latest Github Actions
test-conda-python-3.7-kartothek-master Github Actions
test-conda-python-3.7-pandas-0.24 Github Actions
test-conda-python-3.7-pandas-latest Github Actions
test-conda-python-3.7-spark-v3.1.2 Github Actions
test-conda-python-3.8 Github Actions
test-conda-python-3.8-hypothesis Github Actions
test-conda-python-3.8-pandas-latest Github Actions
test-conda-python-3.8-pandas-nightly Github Actions
test-conda-python-3.8-spark-v3.2.0 Github Actions
test-conda-python-3.9 Github Actions
test-conda-python-3.9-dask-latest Github Actions
test-conda-python-3.9-dask-master Github Actions
test-conda-python-3.9-pandas-master Github Actions
test-conda-python-3.9-spark-master Github Actions
verify-rc-binaries-jars-linux-conda-latest-amd64 Github Actions
verify-rc-binaries-wheels-linux-conda-latest-amd64 Github Actions
verify-rc-binaries-wheels-macos-10.15-amd64-conda Github Actions
verify-rc-binaries-wheels-macos-11-amd64-conda Github Actions
verify-rc-source-cpp-linux-conda-latest-amd64 Github Actions
verify-rc-source-cpp-macos-conda-amd64 Github Actions
verify-rc-source-csharp-linux-conda-latest-amd64 Github Actions
verify-rc-source-go-linux-conda-latest-amd64 Github Actions
verify-rc-source-integration-linux-conda-latest-amd64 Github Actions
verify-rc-source-integration-macos-conda-amd64 Github Actions
verify-rc-source-java-linux-conda-latest-amd64 Github Actions
verify-rc-source-js-linux-conda-latest-amd64 Github Actions
verify-rc-source-python-linux-conda-latest-amd64 Github Actions
verify-rc-source-python-macos-conda-amd64 Github Actions
verify-rc-source-ruby-linux-conda-latest-amd64 Github Actions

@raulcd
Copy link
Member Author

raulcd commented Jul 12, 2022

@kszucs @kou this is pretty minor but let me know if you want me to open a JIRA ticket just because of the possible affected builds.

@kszucs
Copy link
Member

kszucs commented Jul 12, 2022

@raulcd please create a ticket, we may need to cherry pick this change later.

@raulcd raulcd changed the title MINOR: Use -y flag on mamba install to not ask for confirmation ARROW-17050: Use -y flag on mamba install to not ask for confirmation Jul 12, 2022
@github-actions
Copy link

@kou kou changed the title ARROW-17050: Use -y flag on mamba install to not ask for confirmation ARROW-17050: [CI] Use -y flag on mamba install to not ask for confirmation Jul 13, 2022
@kou kou merged commit 8608e19 into apache:master Jul 13, 2022
@ursabot
Copy link

ursabot commented Jul 13, 2022

Benchmark runs are scheduled for baseline = 8a1649a and contender = 8608e19. 8608e19 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.24% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.36% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 8608e193 ec2-t3-xlarge-us-east-2
[Finished] 8608e193 test-mac-arm
[Failed] 8608e193 ursa-i9-9960x
[Finished] 8608e193 ursa-thinkcentre-m75q
[Finished] 8a1649a5 ec2-t3-xlarge-us-east-2
[Finished] 8a1649a5 test-mac-arm
[Failed] 8a1649a5 ursa-i9-9960x
[Finished] 8a1649a5 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants