Skip to content

ARROW-17084: [R] Install the package before linting #13620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonkeane merged 5 commits into from
Aug 2, 2022
Merged

ARROW-17084: [R] Install the package before linting #13620

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8c7531f
install package before linting
dragosmg Jul 15, 2022
a2a424d
try with `pak::pak("local::.")`
dragosmg Jul 15, 2022
e082813
add env var to point to the libarrow.zip
dragosmg Jul 18, 2022
d21e921
lint
dragosmg Jul 18, 2022
112e870
switch to `pak::local_install()` + comment
dragosmg Jul 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/r.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,14 @@ jobs:
shell: Rscript {0}
working-directory: r
run: |
Sys.setenv(
RWINLIB_LOCAL = file.path(Sys.getenv("GITHUB_WORKSPACE"), "r", "windows", "libarrow.zip"),
MAKEFLAGS = paste0("-j", parallel::detectCores()),
ARROW_R_DEV = TRUE,
"_R_CHECK_FORCE_SUGGESTS_" = FALSE
)
# we use pak for package installation since it is faster, safer and more convenient
pak::local_install()
pak::pak("lintr")
lintr::expect_lint_free()
- name: Dump install logs
Expand Down
2 changes: 1 addition & 1 deletion r/tests/testthat/test-dplyr-glimpse.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

# The glimpse output for tests with `example_data` is different on R < 3.6
# because the `lgl` column is generated with `sample()` and the RNG
# algorithm is different in older R versions.
# algorithm is different in older R versions.
skip_on_r_older_than("3.6")

library(dplyr, warn.conflicts = FALSE)
Expand Down