Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-17252: [R] Intermittent valgrind failure (explicit StopProducing approach) #13780

Closed
wants to merge 2 commits into from

Conversation

paleolimbot
Copy link
Member

No description provided.

@paleolimbot
Copy link
Member Author

@github-actions crossbow submit test-r-linux-valgrind

@github-actions
Copy link

github-actions bot commented Aug 2, 2022

@github-actions
Copy link

github-actions bot commented Aug 2, 2022

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@github-actions
Copy link

github-actions bot commented Aug 2, 2022

Revision: e0fab9b

Submitted crossbow builds: ursacomputing/crossbow @ actions-cc5998cdea

Task Status
test-r-linux-valgrind Azure

@pitrou
Copy link
Member

pitrou commented Aug 3, 2022

This looks like a clean approach, but hopefully it will solve the issue as well :-)

Co-authored-by: Antoine Pitrou <pitrou@free.fr>
@paleolimbot
Copy link
Member Author

@github-actions crossbow submit test-r-linux-valgrind

@github-actions
Copy link

github-actions bot commented Aug 3, 2022

Revision: eb8194d

Submitted crossbow builds: ursacomputing/crossbow @ actions-60deab85dd

Task Status
test-r-linux-valgrind Azure

@paleolimbot paleolimbot closed this Aug 7, 2022
@pitrou
Copy link
Member

pitrou commented Aug 8, 2022

@paleolimbot Did you favor another approach? It's not clear here :-)

@paleolimbot
Copy link
Member Author

Thanks - I should have left a note. This approach never solved the issue! Reverting part of the PR that introduced the errors (#13773) and waiting for IO thread pool jobs to finish (#13779) both seem to work. I think we are going with the first option as a patch, although there is a PR in the query engine to support better cancelling of scans (#13782), after which the call to StopProducing() should work (if the leaks we're seeing are, in fact, a result of pending tasks on the IO thread pool, which I think they are). I envision #13706 as the PR that will fix this for good.

@paleolimbot paleolimbot deleted the r-valgrind-4 branch December 9, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants