Add support for downloading flights from alternate endpoints #13900
Conversation
[Java] Fix build
| @@ -87,3 +87,6 @@ cpp/Brewfile.lock.json | |||
| java-dist/ | |||
| java-native-c/ | |||
| java-native-cpp/ | |||
|
|
|||
| # files altered by build | |||
| java/flight/flight-jdbc-driver/src/main/resources/properties/flight.properties | |||
There was a problem hiding this comment.
This file seems to get generated each maven build
There was a problem hiding this comment.
Note #13800 is the up-to-date PR and some of these things were addressed there
| @@ -16,7 +16,7 @@ | |||
| <parent> | |||
| <artifactId>arrow-flight</artifactId> | |||
| <groupId>org.apache.arrow</groupId> | |||
| <version>8.0.0-SNAPSHOT</version> | |||
| <version>9.0.0-SNAPSHOT</version> | |||
| @@ -93,7 +98,6 @@ | |||
| <dependency> | |||
| <groupId>com.google.protobuf</groupId> | |||
| <artifactId>protobuf-java</artifactId> | |||
| <version>${dep.protobuf.version}</version> | |||
There was a problem hiding this comment.
This caused the build to fail
| <exclude>org.slf4j.**</exclude> | ||
| <exclude>org.apache.calcite.**</exclude> |
There was a problem hiding this comment.
Excluding these from shade allowed me to attach a debugger while running the shaded jar from DataGrip, solving some problems I couldn't re-create in junit tests.
|
|
||
| final Map<String, String> keyValuePairs = UrlParser.parse(extraParams, "&"); | ||
| resultMap.putAll(keyValuePairs); | ||
| if(extraParams != null) { |
There was a problem hiding this comment.
This NPEd when there were no extraParams
|
|
||
| import java.util.concurrent.CompletableFuture; | ||
|
|
||
| public class FlightClientCloser implements FlightStream { |
There was a problem hiding this comment.
Ensures FlightSqlClient is closed when the Stream is closed. I'm not sure if this is the right way to do it, but it seemed the least disruptive to the lifecycle of the driver and Future stuff.
| URI uri = ep.getLocations().isEmpty() ? null : ep.getLocations().get(0).getUri(); | ||
| FlightSqlClient sqlClient = this.factory.createConnection(uri); | ||
| FlightStream stream = sqlClient.getStream(ep.getTicket(), getOptions()); | ||
| FlightClientCloser closer = new FlightClientCloser(sqlClient, stream); |
There was a problem hiding this comment.
Wrap the stream to ensure it gets closed.
| * Config options shared by both the {@link ArrowFlightSqlClientHandler.Builder} | ||
| * and the {@link ConnectionFactory}. | ||
| */ | ||
| static class Config { |
There was a problem hiding this comment.
Move the builder config into this data class, so it can be re-used later from the factory without breaking the builder API.
|
This was a redo of rafael-telles#42 |
Try to publish Attach workspace Don't rebuild every time Only need to deploy jdbc-driver Only need to deploy jdbc-driver Might work this time? Keep trying Try to tag Add docker Build from correct directory typo
avantgardnerio
force-pushed
the
bg_pr_eps
branch
from
42cc071 to
bb0fbd5
Compare
|
Will re-open as a new PR against the |
|
@avantgardnerio this came up on dev@ today - are you still planning on re-opening this? Or would you mind if another contributor picked up this PR and continued it? |
At my company, it was concluded that for our use-case, proxying the flights through the "orchastrator" scheduler in Ballista was preferable from a deployment perspective, so I can't justify spending any company time on this. So the short answer is "no".
Of course not, happy to help with backstory, advice, or anything else I can contribute! |
|
Understandable. Thank you! I filed #34532 for posterity. |
extraParamsdep.protobuf.versionbuild error@jduo @jayhomn-bitquill @andygrove
See rafael-telles#42 for more detail.