Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-17732: [Docs][Java] Add minimal JDBC driver docs #14137

Merged
merged 2 commits into from
Oct 19, 2022

Conversation

lidavidm
Copy link
Member

No description provided.

@lidavidm
Copy link
Member Author

Accompanies apache/arrow-site#236

Rendered:

image

@nealrichardson
Copy link
Member

@lidavidm I think ARROW-17332 is not the right jira

@lidavidm lidavidm changed the title ARROW-17332: [Docs][Java] Add minimal JDBC driver docs ARROW-17732: [Docs][Java] Add minimal JDBC driver docs Sep 15, 2022
@lidavidm
Copy link
Member Author

whoops, that should've been 17732, thanks

@github-actions
Copy link

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@github-actions
Copy link

@lidavidm
Copy link
Member Author

CC @jduo, does this look reasonable as a basic landing page?

@lidavidm
Copy link
Member Author

@davisusanibar @lwhite1 could one of you give this a skim? It would be good to have documentation for our shiny new driver.

Copy link
Contributor

@lwhite1 lwhite1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion. Otherwise LGTM.


The URI format is as follows::

jdbc:arrow-flight-sql://HOSTNAME:PORT[/?param1=val1&param2=val2&...]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably just me but I find these URI format definitions to be a little cryptic. Maybe include an example string with a couple of parameters so people have something concrete to refer to?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good idea. I added an example with some prose to explain the parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants