Skip to content

ARROW-17842: [C++][CI] Use Brew installed clang for MacOS verify-rc #14236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kou merged 2 commits into from
Sep 27, 2022
Merged

ARROW-17842: [C++][CI] Use Brew installed clang for MacOS verify-rc #14236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a888af0
use brew installed llvm for mac verify rc
js8544 Sep 25, 2022
4120ecd
avoid clang15 boost issue
js8544 Sep 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cpp/src/arrow/flight/sql/example/sqlite_server.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
#include "arrow/flight/sql/example/sqlite_server.h"

#include <sqlite3.h>

#define BOOST_NO_CXX98_FUNCTION_BASE // ARROW-17805
#include <boost/algorithm/string.hpp>
#include <mutex>
#include <random>
Expand Down
1 change: 1 addition & 0 deletions cpp/src/arrow/flight/sql/example/sqlite_statement.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

#include <sqlite3.h>

#define BOOST_NO_CXX98_FUNCTION_BASE // ARROW-17805
#include <boost/algorithm/string.hpp>

#include "arrow/flight/sql/column_metadata.h"
Expand Down
2 changes: 1 addition & 1 deletion cpp/src/arrow/flight/sql/test_app_cli.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
// under the License.

#include <gflags/gflags.h>

#define BOOST_NO_CXX98_FUNCTION_BASE // ARROW-17805
#include <boost/algorithm/string.hpp>
#include <iostream>
#include <memory>
Expand Down
2 changes: 2 additions & 0 deletions dev/tasks/verify-rc/github.macos.amd64.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,4 +71,6 @@ jobs:
USE_CONDA: 1
{% endif %}
run: |
export CC=$(brew --prefix llvm)/bin/clang
export CXX=$(brew --prefix llvm)/bin/clang++
arrow/dev/release/verify-release-candidate.sh {{ release|default("") }} {{ rc|default("") }}