-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-319: Add canonical Arrow Schema json representation #158
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adeneche
reviewed
Oct 6, 2016
public static ArrowVectorType fromName(String name) { | ||
ArrowVectorType type = typeByName.get(name); | ||
if (type == null) { | ||
throw new IllegalArgumentException("Unlnown type " + name); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unknown
adeneche
approved these changes
Oct 6, 2016
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM. It would be preferable if another dev takes a look at it too as I am unfamiliar with this set of changes
wesm
pushed a commit
to wesm/arrow
that referenced
this pull request
Sep 2, 2018
At the moment this is just move of the existing code into the state where it compiles. Outstanding work includes: - [x] Understand the issues with ParquetException typeid matching in the tests *on macOS*. @wesm We already had this problem and you fixed it somewhere. Do you remember the solution? - [x] Understand why BoolenType tests break with a Thrift exception - [ ] Add functions that read directly into Arrow memory and not intermediate structures. Author: Uwe L. Korn <uwelk@xhochy.com> Author: Korn, Uwe <Uwe.Korn@blue-yonder.com> Closes apache#158 from xhochy/PARQUET-712 and squashes the following commits: e55ab1f [Uwe L. Korn] verbose ctest output 62f0f88 [Uwe L. Korn] Add static linkage fc2c316 [Uwe L. Korn] Style fixes 3f3e24b [Uwe L. Korn] Fix templating problem 45de044 [Uwe L. Korn] Style fixes for IO 1d39a60 [Uwe L. Korn] Import MemoryPool instead of declaring it 251262a [Uwe L. Korn] Style fixes e0e1518 [Uwe L. Korn] Build parquet_arrow in Travis 874b33d [Korn, Uwe] Add boost libraries for Arrow 142a364 [Korn, Uwe] PARQUET-712: Add library to read into Arrow memory
wesm
pushed a commit
to wesm/arrow
that referenced
this pull request
Sep 4, 2018
At the moment this is just move of the existing code into the state where it compiles. Outstanding work includes: - [x] Understand the issues with ParquetException typeid matching in the tests *on macOS*. @wesm We already had this problem and you fixed it somewhere. Do you remember the solution? - [x] Understand why BoolenType tests break with a Thrift exception - [ ] Add functions that read directly into Arrow memory and not intermediate structures. Author: Uwe L. Korn <uwelk@xhochy.com> Author: Korn, Uwe <Uwe.Korn@blue-yonder.com> Closes apache#158 from xhochy/PARQUET-712 and squashes the following commits: e55ab1f [Uwe L. Korn] verbose ctest output 62f0f88 [Uwe L. Korn] Add static linkage fc2c316 [Uwe L. Korn] Style fixes 3f3e24b [Uwe L. Korn] Fix templating problem 45de044 [Uwe L. Korn] Style fixes for IO 1d39a60 [Uwe L. Korn] Import MemoryPool instead of declaring it 251262a [Uwe L. Korn] Style fixes e0e1518 [Uwe L. Korn] Build parquet_arrow in Travis 874b33d [Korn, Uwe] Add boost libraries for Arrow 142a364 [Korn, Uwe] PARQUET-712: Add library to read into Arrow memory Change-Id: I893a02104d7f561fab24cf2fab2ba66dd61b6fd1
wesm
pushed a commit
to wesm/arrow
that referenced
this pull request
Sep 6, 2018
At the moment this is just move of the existing code into the state where it compiles. Outstanding work includes: - [x] Understand the issues with ParquetException typeid matching in the tests *on macOS*. @wesm We already had this problem and you fixed it somewhere. Do you remember the solution? - [x] Understand why BoolenType tests break with a Thrift exception - [ ] Add functions that read directly into Arrow memory and not intermediate structures. Author: Uwe L. Korn <uwelk@xhochy.com> Author: Korn, Uwe <Uwe.Korn@blue-yonder.com> Closes apache#158 from xhochy/PARQUET-712 and squashes the following commits: e55ab1f [Uwe L. Korn] verbose ctest output 62f0f88 [Uwe L. Korn] Add static linkage fc2c316 [Uwe L. Korn] Style fixes 3f3e24b [Uwe L. Korn] Fix templating problem 45de044 [Uwe L. Korn] Style fixes for IO 1d39a60 [Uwe L. Korn] Import MemoryPool instead of declaring it 251262a [Uwe L. Korn] Style fixes e0e1518 [Uwe L. Korn] Build parquet_arrow in Travis 874b33d [Korn, Uwe] Add boost libraries for Arrow 142a364 [Korn, Uwe] PARQUET-712: Add library to read into Arrow memory Change-Id: I893a02104d7f561fab24cf2fab2ba66dd61b6fd1
wesm
pushed a commit
to wesm/arrow
that referenced
this pull request
Sep 7, 2018
At the moment this is just move of the existing code into the state where it compiles. Outstanding work includes: - [x] Understand the issues with ParquetException typeid matching in the tests *on macOS*. @wesm We already had this problem and you fixed it somewhere. Do you remember the solution? - [x] Understand why BoolenType tests break with a Thrift exception - [ ] Add functions that read directly into Arrow memory and not intermediate structures. Author: Uwe L. Korn <uwelk@xhochy.com> Author: Korn, Uwe <Uwe.Korn@blue-yonder.com> Closes apache#158 from xhochy/PARQUET-712 and squashes the following commits: e55ab1f [Uwe L. Korn] verbose ctest output 62f0f88 [Uwe L. Korn] Add static linkage fc2c316 [Uwe L. Korn] Style fixes 3f3e24b [Uwe L. Korn] Fix templating problem 45de044 [Uwe L. Korn] Style fixes for IO 1d39a60 [Uwe L. Korn] Import MemoryPool instead of declaring it 251262a [Uwe L. Korn] Style fixes e0e1518 [Uwe L. Korn] Build parquet_arrow in Travis 874b33d [Korn, Uwe] Add boost libraries for Arrow 142a364 [Korn, Uwe] PARQUET-712: Add library to read into Arrow memory Change-Id: I893a02104d7f561fab24cf2fab2ba66dd61b6fd1
wesm
pushed a commit
to wesm/arrow
that referenced
this pull request
Sep 8, 2018
At the moment this is just move of the existing code into the state where it compiles. Outstanding work includes: - [x] Understand the issues with ParquetException typeid matching in the tests *on macOS*. @wesm We already had this problem and you fixed it somewhere. Do you remember the solution? - [x] Understand why BoolenType tests break with a Thrift exception - [ ] Add functions that read directly into Arrow memory and not intermediate structures. Author: Uwe L. Korn <uwelk@xhochy.com> Author: Korn, Uwe <Uwe.Korn@blue-yonder.com> Closes apache#158 from xhochy/PARQUET-712 and squashes the following commits: e55ab1f [Uwe L. Korn] verbose ctest output 62f0f88 [Uwe L. Korn] Add static linkage fc2c316 [Uwe L. Korn] Style fixes 3f3e24b [Uwe L. Korn] Fix templating problem 45de044 [Uwe L. Korn] Style fixes for IO 1d39a60 [Uwe L. Korn] Import MemoryPool instead of declaring it 251262a [Uwe L. Korn] Style fixes e0e1518 [Uwe L. Korn] Build parquet_arrow in Travis 874b33d [Korn, Uwe] Add boost libraries for Arrow 142a364 [Korn, Uwe] PARQUET-712: Add library to read into Arrow memory Change-Id: I893a02104d7f561fab24cf2fab2ba66dd61b6fd1
rafael-telles
pushed a commit
to rafael-telles/arrow
that referenced
this pull request
Oct 19, 2021
…eter-binding [Flight SQL C++] Implement parameter binding on execute of PreparedStatement on Flight SQL Client.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.