ARROW-3061: [JAVA] Fix BufferAllocator#getHeadroom #2434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Buffer allocator headroom is the minimum between the parent headroom and the memory available for the current allocator. But if the allocator also has some reserved memory (which has been accounted for in the parent allocator), the headroom is actually less than what is currently available. For example if parent allocator limit is 10, and child allocator has 2 of reserved memory, assuming that no other memory has been allocated, headroom for the child allocator is 10, not 8. Fix Accountant#getHeadroom to take into account reserved memory into its calculation.
siddharthteotia
pushed a commit
to siddharthteotia/arrow
that referenced
this pull request
Sep 7, 2018
Buffer allocator headroom is the minimum between the parent headroom and the memory available for the current allocator. But if the allocator also has some reserved memory (which has been accounted for in the parent allocator), the headroom is actually less than what is currently available. For example if parent allocator limit is 10, and child allocator has 2 of reserved memory, assuming that no other memory has been allocated, headroom for the child allocator is 10, not 8. Fix Accountant#getHeadroom to take into account reserved memory into its calculation.
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
Buffer allocator headroom is the minimum between the parent headroom and the memory available for the current allocator. But if the allocator also has some reserved memory (which has been accounted for in the parent allocator), the headroom is actually less than what is currently available. For example if parent allocator limit is 10, and child allocator has 2 of reserved memory, assuming that no other memory has been allocated, headroom for the child allocator is 10, not 8. Fix Accountant#getHeadroom to take into account reserved memory into its calculation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buffer allocator headroom is the minimum between the parent headroom
and the memory available for the current allocator. But if the allocator
also has some reserved memory (which has been accounted for in the parent
allocator), the headroom is actually less than what is currently available.
For example if parent allocator limit is 10, and child allocator has 2 of
reserved memory, assuming that no other memory has been allocated, headroom
for the child allocator is 10, not 8.
Fix Accountant#getHeadroom to take into account reserved memory into its
calculation.