Skip to content

ARROW-1949: [Python/C++] Add option to Array.from_pandas and pyarrow.array to perform unsafe casts #2497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kszucs wants to merge 6 commits into from
Closed

ARROW-1949: [Python/C++] Add option to Array.from_pandas and pyarrow.array to perform unsafe casts #2497

kszucs wants to merge 6 commits into from

Conversation

@kszucs
Copy link
Member

@kszucs kszucs commented Aug 29, 2018

No description provided.

kszucs
kszucs commented Sep 1, 2018
View reviewed changes
python/pyarrow/array.pxi Outdated
DataType type,
CMemoryPool* pool, c_bool from_pandas):
DataType type, CMemoryPool* pool, c_bool from_pandas,
c_bool safe):
Copy link
Member Author

@kszucs kszucs Sep 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Implementation is missing from here

Copy link
Member Author

@kszucs kszucs Sep 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ConvertPySequence assumes strict conversion if datatype is explicitly passed.

@kszucs kszucs changed the title WIP: ARROW-1949: [Python/C++] Add option to Array.from_pandas and pyarrow.array to perform unsafe casts ARROW-1949: [Python/C++] Add option to Array.from_pandas and pyarrow.array to perform unsafe casts Sep 2, 2018
@kszucs kszucs mentioned this pull request Sep 2, 2018
Closed
@codecov-io
Copy link

codecov-io commented Sep 2, 2018

Codecov Report

Merging #2497 into master will increase coverage by 1.27%.
The diff coverage is 64.1%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2497      +/-   ##
==========================================
+ Coverage   86.17%   87.44%   +1.27%     
==========================================
  Files         308      246      -62     
  Lines       47102    43433    -3669     
==========================================
- Hits        40589    37980    -2609     
+ Misses       6439     5453     -986     
+ Partials       74        0      -74
Impacted Files Coverage Δ
python/pyarrow/tests/test_array.py 98.96% <100%> (+0.02%) ⬆️
python/pyarrow/array.pxi 68.93% <43.75%> (+0.36%) ⬆️
cpp/src/arrow/python/numpy_to_arrow.cc 93.53% <50%> (-0.58%) ⬇️
rust/src/record_batch.rs
go/arrow/datatype_nested.go
rust/src/array.rs
go/arrow/math/uint64_amd64.go
go/arrow/internal/testing/tools/bool.go
go/arrow/internal/bitutil/bitutil.go
go/arrow/memory/memory_avx2_amd64.go
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c282a14...f352c47. Read the comment docs.

@kszucs kszucs requested a review from xhochy September 3, 2018 12:03
xhochy
xhochy approved these changes Sep 4, 2018
View reviewed changes
Copy link
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@xhochy xhochy closed this in a712165 Sep 4, 2018
@kszucs
Copy link
Member Author

kszucs commented Sep 4, 2018

Thanks Uwe!

wesm pushed a commit that referenced this pull request Sep 8, 2018
@kszucs @wesm
ARROW-2799: [Python] Add safe option to Table.from_pandas to avoid un…
e751999 
…safe casts

Depends on both #2497 and #2503

Author: Krisztián Szűcs <szucs.krisztian@gmail.com>

Closes #2504 from kszucs/ARROW-2799 and squashes the following commits:

7bf9efd <Krisztián Szűcs> unsafe table creation during parquet dataset partitioning
38dfea3 <Krisztián Szűcs> disallow float truncation by default
515a393 <Krisztián Szűcs> Table.from_pandas safe option
2c82074 <Krisztián Szűcs> check-format
80e1478 <Krisztián Szűcs> lint
e0838ce <Krisztián Szűcs> wire CastOptions through the API
2961094 <Krisztián Szűcs> set allow_float_truncate true by default
194e476 <Krisztián Szűcs> allow truncate float option and its implementation
@asfimport asfimport mentioned this pull request Sep 4, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xhochy xhochy xhochy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kszucs @codecov-io @xhochy