Skip to content

ARROW-437: [C++} Fix clang compiler warning #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wesm wants to merge 1 commit into from
Closed

ARROW-437: [C++} Fix clang compiler warning #254

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion cpp/src/arrow/array.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,9 @@ class ARROW_EXPORT NumericArray : public PrimitiveArray {
return PrimitiveArray::EqualsExact(static_cast<const PrimitiveArray&>(other));
}

bool ApproxEquals(const std::shared_ptr<Array>& arr) const { return Equals(arr); }
bool ApproxEquals(const std::shared_ptr<Array>& arr) const override {
return Equals(arr);
}

bool RangeEquals(int32_t start_idx, int32_t end_idx, int32_t other_start_idx,
const ArrayPtr& arr) const override {
Expand Down