Skip to content

ARROW-3219: [C++] Use Win32 API in MinGW build #2544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kou wants to merge 1 commit into from
Closed

ARROW-3219: [C++] Use Win32 API in MinGW build #2544

kou wants to merge 1 commit into from

Conversation

@kou
Copy link
Member

@kou kou commented Sep 11, 2018

No description provided.

pitrou
pitrou approved these changes Sep 11, 2018
View reviewed changes
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is it enough to have Arrow compile with MinGW?

@wesm wesm closed this in c898ba0 Sep 11, 2018
@kou kou deleted the cpp-use-win32-api-with-mingw branch September 12, 2018 00:13
@kou
Copy link
Member Author

kou commented Sep 12, 2018

Yes.

But we need changes for build system. I can build with MinGW but can't build tests for now. We can enable CI on AppVeyor when we can build tests.

All changes to build Arrow except test have been merged except #2483 (system zlib) and #2359 (insecure warnings).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitrou pitrou pitrou approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kou @pitrou