-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-3276: [Packaging] Add support for Parquet deb/rpm packages #2603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Great! Thanks @kou! How should we handle parquet versioning? Will we have distinct git tags for parquet as well as separate release? |
|
Do you mean that Apache Arrow and Apache Parquet C++ use different versions? If we use the different versions for Apache Arrow and Apache Parquet C++, we should create two |
This is up to the Parquet community. To avoid complications we may just want to bundle the Parquet libraries in the same package as libarrow.so |
|
Just asking because the two most recent parquet-cpp version numbers are |
|
My thought was to bundle everything as a unit, to avoid having to worry about release coordination between Apache Arrow and Apache Parquet |
|
I rethought about this. We should use the same version as Apache Arrow for Apache Parquet C++ package. Because both .deb/.rpm use one version for one source archive. We put Apache Arrow and Apache Parquet C++ into one source archive regardless of Apache Parquet C++ version. So the approach in this pull request is reasonable. If there are no more concerns, I'll merge this pull request. |
| Depends: | ||
| ${misc:Depends}, | ||
| ${shlibs:Depends} | ||
| Description: Apache Parquet is a columner storage format |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a typo columnAr.
We might want to highlight, that it's the cpp implementation, e.g:
C++ library to read and write Apache Parquet columnar storage format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh! Thanks for fixing the typo.
C++ information will be useful. We'll add it when we add packages for GLib bindings.
kszucs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kou!
No description provided.