-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-3966 [Java] JDBC Column Metadata in Arrow Field Metadata #3134
Closed
+295
−42
Closed
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
5af1b5b
Separating out the field-type creation from the field creation.
523387f
Updating the API to support an optional 'includeMetadata' field.
a78c770
Updating Javadocs.
da77cbe
Creating a configuration class for the JDBC-to-Arrow converter.
b270044
Updated validaton & documentation, and unit tests for the new JdbcToA…
df632e3
Updating the SQL tests to include JdbcToArrowConfig versions.
fe097c8
Merge branch 'jdbc-to-arrow-config' into jdbc-column-metadata
e34a9e7
Fixing formatting.
4f1260c
Adding documentation for public static VectorSchemaRoot sqlToArrow(Re…
8d6cf00
Documentation for public static VectorSchemaRoot sqlToArrow(Connectio…
b5b0cb1
Merge branch 'jdbc-to-arrow-config' into jdbc-column-metadata
68c91e7
Modifying the jdbcToArrowSchema and jdbcToArrowVectors methods to rec…
5bfd6a2
Merge branch 'jdbc-to-arrow-config' into jdbc-column-metadata
a6fb1be
Fixing function call
bb3165b
Updating the function calls to use the JdbcToArrowConfig versions.
7e9ce37
Merge branch 'jdbc-to-arrow-config' into jdbc-column-metadata
7b4527c
Test for the include-metadata flag in the configuration.
72d64cc
Affirming the field metadata is empty when the configuration excludes…
03091a8
Unit tests for including result set metadata.
881c6c8
Merge pull request #1 from apache/master
mikepigott 1ceac9e
Merge branch 'master' into jdbc-column-metadata
d847ebc
Fixing file location
3b17c29
Merge pull request #2 from apache/master
mikepigott e5b19ee
Merge pull request #3 from apache/master
mikepigott 789c8c8
Merge pull request #4 from apache/master
mikepigott 509a1cc
Merge pull request #5 from apache/master
mikepigott 4a6de86
Merge branch 'master' into jdbc-column-metadata
69022c2
ARROW-3966: Fixing merge.
2928513
ARROW-3966: Moving the metadata flag assignment into the builder.
cfb2ba6
ARROW-3966: Using a helper method for building a UTC calendar with ro…
cc6cc88
ARROW-3966: Using a 1:N loop instead of a 0:N-1 loop for fewer index …
65741a9
ARROW-3966: Code review feedback
e9a9b2b
Merge pull request #6 from apache/master
mikepigott 7049c36
Merge branch 'master' into jdbc-column-metadata
02f2f34
ARROW-3966: Picking up lost change to support null calendars.
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Separating out the field-type creation from the field creation.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the use of FieldType object instead of creating Field object in each case stmt. I am fine with this.