Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-3792: [C++] Writing a list-type chunked column to Parquet fails if any chunk is 0-length #3141

Closed
wants to merge 1 commit into from

Conversation

wesm
Copy link
Member

@wesm wesm commented Dec 10, 2018

Thanks to @tanyaschlusser to providing a minimal reproduction to help find the underlying problem

Change-Id: If04161ed46373d1fec08ab1db969d90465e0db3f
@codecov-io
Copy link

Codecov Report

Merging #3141 into master will decrease coverage by <.01%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3141      +/-   ##
==========================================
- Coverage   87.17%   87.16%   -0.01%     
==========================================
  Files         494      494              
  Lines       69612    69622      +10     
==========================================
+ Hits        60682    60684       +2     
- Misses       8833     8837       +4     
- Partials       97      101       +4
Impacted Files Coverage Δ
python/pyarrow/tests/test_parquet.py 97.42% <100%> (+0.01%) ⬆️
cpp/src/parquet/arrow/writer.cc 91.23% <50%> (-0.17%) ⬇️
go/arrow/math/int64_avx2_amd64.go 0% <0%> (-100%) ⬇️
go/arrow/memory/memory_avx2_amd64.go 0% <0%> (-100%) ⬇️
go/arrow/math/float64_avx2_amd64.go 0% <0%> (-100%) ⬇️
go/arrow/math/uint64_avx2_amd64.go 0% <0%> (-100%) ⬇️
go/arrow/memory/memory_amd64.go 28.57% <0%> (-14.29%) ⬇️
go/arrow/math/math_amd64.go 31.57% <0%> (-5.27%) ⬇️
go/arrow/math/float64_amd64.go 33.33% <0%> (ø) ⬆️
go/arrow/math/int64_amd64.go 33.33% <0%> (ø) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4063ed...1ed82a5. Read the comment docs.

Copy link
Member

@kszucs kszucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants