Skip to content

GH-34479: [Java] java-jars failing due to conflicting slf4j bindings #34480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lidavidm merged 1 commit into from
Mar 7, 2023
Merged

GH-34479: [Java] java-jars failing due to conflicting slf4j bindings #34480

lidavidm merged 1 commit into from
Mar 7, 2023

Conversation

@js8544
Copy link
Collaborator

@js8544 js8544 commented Mar 7, 2023 •
edited by github-actions bot
Loading

Describe the bug, including details regarding any error messages, version, and platform.

Example failure build: https://github.com/ursacomputing/crossbow/actions/runs/4341450290/jobs/7582202736

SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in [jar:file:/Users/runner/.m2/repository/org/slf4j/slf4j-reload4j/1.7.36/slf4j-reload4j-1.7.36.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/Users/runner/.m2/repository/ch/qos/logback/logback-classic/1.2.3/logback-classic-1.2.3.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Detected both log4j-over-slf4j.jar AND bound slf4j-reload4j.jar on the class path, preempting StackOverflowError.
SLF4J: See also http://www.slf4j.org/codes.html#log4jDelegationLoop for more details.

Caused by #13861, hadoop-common 3.3.3 added dependency on reload4j( https://hadoop.apache.org/docs/r3.3.3/hadoop-project-dist/hadoop-common/release/3.3.3/RELEASENOTES.3.3.3.html). We should exclude slf4j-reload4j as suggested on the release note.

Component(s)

Java

@js8544 js8544 requested a review from lidavidm as a code owner March 7, 2023 09:54
@github-actions
Copy link

github-actions bot commented Mar 7, 2023

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

⚠️ GitHub issue #34479 has been automatically assigned in GitHub to PR creator.

@js8544
Copy link
Collaborator Author

js8544 commented Mar 7, 2023

@github-actions crossbow submit java-jars

@github-actions github-actions bot added the awaiting review Awaiting review label Mar 7, 2023
@github-actions
Copy link

github-actions bot commented Mar 7, 2023

Revision: 793515d

Submitted crossbow builds: ursacomputing/crossbow @ actions-c64c328b9c

Task Status
java-jars Github Actions

lidavidm
lidavidm approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@lidavidm lidavidm merged commit 2e4a96c into apache:main Mar 7, 2023
@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Mar 7, 2023
@ursabot
Copy link

ursabot commented Mar 7, 2023

Benchmark runs are scheduled for baseline = fc95019 and contender = 2e4a96c. 2e4a96c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.46% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.57% ⬆️0.03%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 2e4a96c6 ec2-t3-xlarge-us-east-2
[Failed] 2e4a96c6 test-mac-arm
[Finished] 2e4a96c6 ursa-i9-9960x
[Finished] 2e4a96c6 ursa-thinkcentre-m75q
[Finished] fc950192 ec2-t3-xlarge-us-east-2
[Failed] fc950192 test-mac-arm
[Finished] fc950192 ursa-i9-9960x
[Finished] fc950192 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Mar 14, 2023

['Python', 'R'] benchmarks have high level of regressions.
test-mac-arm

@kou kou mentioned this pull request Mar 16, 2023
Merged
pribor pushed a commit to GlobalWebIndex/arrow that referenced this pull request Oct 24, 2025
@js8544 @kou
apacheGH-34479: [Java] java-jars failing due to conflicting slf4j bin…
dbf464c 
…dings (apache#34480)

### Describe the bug, including details regarding any error messages, version, and platform.

Example failure build: https://github.com/ursacomputing/crossbow/actions/runs/4341450290/jobs/7582202736

> SLF4J: Class path contains multiple SLF4J bindings.
> SLF4J: Found binding in [jar:file:/Users/runner/.m2/repository/org/slf4j/slf4j-reload4j/1.7.36/slf4j-reload4j-1.7.36.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: Found binding in [jar:file:/Users/runner/.m2/repository/ch/qos/logback/logback-classic/1.2.3/logback-classic-1.2.3.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
> SLF4J: Detected both log4j-over-slf4j.jar AND bound slf4j-reload4j.jar on the class path, preempting StackOverflowError. 
> SLF4J: See also http://www.slf4j.org/codes.html#log4jDelegationLoop for more details.

Caused by apache#13861, hadoop-common 3.3.3 added dependency on reload4j( https://hadoop.apache.org/docs/r3.3.3/hadoop-project-dist/hadoop-common/release/3.3.3/RELEASENOTES.3.3.3.html). We should exclude slf4j-reload4j as suggested on the release note.

### Component(s)

Java
* Closes: apache#34479

Authored-by: Jin Shang <shangjin1997@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lidavidm lidavidm lidavidm approved these changes

Assignees

No one assigned

Labels

awaiting committer review Awaiting committer review Component: Java

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Java] java-jars failing due to conflicting slf4j bindings

3 participants

@js8544 @ursabot @lidavidm