Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-34669: [Packaging][Conda] Update arrow feedstock dependencies #34652

Merged
merged 14 commits into from
Apr 11, 2023

Conversation

h-vetinari
Copy link
Contributor

@h-vetinari h-vetinari commented Mar 21, 2023

As well as other changes that happened on the feedstock since #14832

@github-actions
Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@github-actions github-actions bot added the awaiting review Awaiting review label Mar 21, 2023
@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Mar 21, 2023
@h-vetinari
Copy link
Contributor Author

@github-actions crossbow submit -g conda

@github-actions
Copy link

Revision: ed78d6a

Submitted crossbow builds: ursacomputing/crossbow @ actions-3363969e3b

Task Status
conda-clean Azure
conda-linux-aarch64-cpu-py3 Azure
conda-linux-aarch64-cpu-r41 Azure
conda-linux-aarch64-cpu-r42 Azure
conda-linux-ppc64le-cpu-py3 Azure
conda-linux-x64-cpu-py3 Azure
conda-linux-x64-cpu-r41 Azure
conda-linux-x64-cpu-r42 Azure
conda-linux-x64-cuda-py3 Azure
conda-osx-arm64-cpu-py3 Azure
conda-osx-arm64-cpu-r41 Azure
conda-osx-arm64-cpu-r42 Azure
conda-osx-x64-cpu-py3 Azure
conda-osx-x64-cpu-r41 Azure
conda-osx-x64-cpu-r42 Azure
conda-win-x64-cpu-py3 Azure
conda-win-x64-cpu-r41 Azure
conda-win-x64-cuda-py3 Azure

@h-vetinari
Copy link
Contributor Author

@github-actions crossbow submit -g conda

@github-actions
Copy link

Revision: fead3ed

Submitted crossbow builds: ursacomputing/crossbow @ actions-2def4fe972

Task Status
conda-clean Azure
conda-linux-aarch64-cpu-py3 Azure
conda-linux-aarch64-cpu-r41 Azure
conda-linux-aarch64-cpu-r42 Azure
conda-linux-ppc64le-cpu-py3 Azure
conda-linux-x64-cpu-py3 Azure
conda-linux-x64-cpu-r41 Azure
conda-linux-x64-cpu-r42 Azure
conda-linux-x64-cuda-py3 Azure
conda-osx-arm64-cpu-py3 Azure
conda-osx-arm64-cpu-r41 Azure
conda-osx-arm64-cpu-r42 Azure
conda-osx-x64-cpu-py3 Azure
conda-osx-x64-cpu-r41 Azure
conda-osx-x64-cpu-r42 Azure
conda-win-x64-cpu-py3 Azure
conda-win-x64-cpu-r41 Azure
conda-win-x64-cuda-py3 Azure

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you open an issue for this pull request and associate it with this pull request?

else()
set(ARROW_GDB_AUTO_LOAD_LIBARROW_GDB_DIR
- "${ARROW_GDB_AUTO_LOAD_DIR}/${CMAKE_INSTALL_FULL_LIBDIR}")
+ "${ARROW_GDB_AUTO_LOAD_DIR}/replace_this_section_with_absolute_slashed_path_to_CONDA_PREFIX/lib/")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you open an issue for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done: #34670

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Mar 21, 2023
@h-vetinari h-vetinari changed the title update arrow feedstock dependencies GH-34669: update arrow feedstock dependencies Mar 22, 2023
@github-actions
Copy link

@github-actions
Copy link

⚠️ GitHub issue #34669 has been automatically assigned in GitHub to PR creator.

@h-vetinari
Copy link
Contributor Author

Could you open an issue for this pull request and associate it with this pull request?

Done.

@h-vetinari
Copy link
Contributor Author

@github-actions crossbow submit -g conda

@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Mar 22, 2023
@github-actions
Copy link

Revision: d55f2d4

Submitted crossbow builds: ursacomputing/crossbow @ actions-7bc0e8ac31

Task Status
conda-clean Azure
conda-linux-aarch64-cpu-py3 Azure
conda-linux-aarch64-cpu-r41 Azure
conda-linux-aarch64-cpu-r42 Azure
conda-linux-ppc64le-cpu-py3 Azure
conda-linux-x64-cpu-py3 Azure
conda-linux-x64-cpu-r41 Azure
conda-linux-x64-cpu-r42 Azure
conda-linux-x64-cuda-py3 Azure
conda-osx-arm64-cpu-py3 Azure
conda-osx-arm64-cpu-r41 Azure
conda-osx-arm64-cpu-r42 Azure
conda-osx-x64-cpu-py3 Azure
conda-osx-x64-cpu-r41 Azure
conda-osx-x64-cpu-r42 Azure
conda-win-x64-cpu-py3 Azure
conda-win-x64-cpu-r41 Azure
conda-win-x64-cuda-py3 Azure

@assignUser
Copy link
Member

Thanks a lot for your work on the arrow feedstocks here and on conda-forge @h-vetinari !

Does this sync changes from the conda-forge feedstock into the arrow repo or will these changes also be used by the upstream repo?

@kou kou changed the title GH-34669: update arrow feedstock dependencies GH-34669: [Packaging][Conda] Update arrow feedstock dependencies Mar 22, 2023
@h-vetinari
Copy link
Contributor Author

Does this sync changes from the conda-forge feedstock into the arrow repo or will these changes also be used by the upstream repo?

I sync both ways. All the changes here originated on the feedstock, though I saw that there was one change here that removed a build option, which I'll mirror back to the feedstock as soon as arrow 12 is released.

@assignUser
Copy link
Member

Ah great, thanks again. I don't think we have any documentation about the whole process of syncing and maintaining the conda-forge feedstock other than a small checkbox as a post-release task... do you think it would make sense to document the process to make it easier for the rest of the community to aid in this process?

@h-vetinari
Copy link
Contributor Author

do you think it would make sense to document the process to make it easier for the rest of the community to aid in this process?

I've been piecing things together myself as well, but I do have a bunch of experience from the conda-forge side. I could write something up - could you tell me where that should go?

@assignUser
Copy link
Member

Oh great! I think that would be best located in the post release task section of the release management guide: https://github.com/apache/arrow/blob/main/docs/source/developers/release.rst

@h-vetinari
Copy link
Contributor Author

@github-actions crossbow submit -g conda

@github-actions
Copy link

github-actions bot commented Apr 8, 2023

Revision: cbd13db

Submitted crossbow builds: ursacomputing/crossbow @ actions-60f7fe1922

Task Status
conda-clean Azure
conda-linux-aarch64-cpu-py3 Azure
conda-linux-aarch64-cpu-r42 Azure
conda-linux-ppc64le-cpu-py3 Azure
conda-linux-x64-cpu-py3 Azure
conda-linux-x64-cpu-r42 Azure
conda-linux-x64-cuda-py3 Azure
conda-osx-arm64-cpu-py3 Azure
conda-osx-arm64-cpu-r42 Azure
conda-osx-x64-cpu-py3 Azure
conda-osx-x64-cpu-r42 Azure
conda-win-x64-cpu-py3 Azure
conda-win-x64-cpu-r41 Azure
conda-win-x64-cuda-py3 Azure

@kou
Copy link
Member

kou commented Apr 8, 2023

Could you rebase on the current main for R errors?

@h-vetinari
Copy link
Contributor Author

@github-actions crossbow submit -g conda

@github-actions
Copy link

github-actions bot commented Apr 9, 2023

Revision: 40180fe

Submitted crossbow builds: ursacomputing/crossbow @ actions-e13c3a337a

Task Status
conda-clean Azure
conda-linux-aarch64-cpu-py3 Azure
conda-linux-aarch64-cpu-r42 Azure
conda-linux-ppc64le-cpu-py3 Azure
conda-linux-x64-cpu-py3 Azure
conda-linux-x64-cpu-r42 Azure
conda-linux-x64-cuda-py3 Azure
conda-osx-arm64-cpu-py3 Azure
conda-osx-arm64-cpu-r42 Azure
conda-osx-x64-cpu-py3 Azure
conda-osx-x64-cpu-r42 Azure
conda-win-x64-cpu-py3 Azure
conda-win-x64-cpu-r41 Azure
conda-win-x64-cuda-py3 Azure

@h-vetinari
Copy link
Contributor Author

Still fails with the acero errors for R on windows...

@h-vetinari
Copy link
Contributor Author

Are other timeout errors related to this change?

Possibly. I'd just switch off running the test suite for the builds running in emulation TBH.

@h-vetinari
Copy link
Contributor Author

@github-actions crossbow submit -g conda

@github-actions
Copy link

Revision: 30da1a6

Submitted crossbow builds: ursacomputing/crossbow @ actions-e39652519d

Task Status
conda-clean Azure
conda-linux-aarch64-cpu-py3 Azure
conda-linux-aarch64-cpu-r42 Azure
conda-linux-ppc64le-cpu-py3 Azure
conda-linux-x64-cpu-py3 Azure
conda-linux-x64-cpu-r42 Azure
conda-linux-x64-cuda-py3 Azure
conda-osx-arm64-cpu-py3 Azure
conda-osx-arm64-cpu-r42 Azure
conda-osx-x64-cpu-py3 Azure
conda-osx-x64-cpu-r42 Azure
conda-win-x64-cpu-py3 Azure
conda-win-x64-cpu-r41 Azure
conda-win-x64-cuda-py3 Azure

@h-vetinari
Copy link
Contributor Author

This is now passing except R on windows. CC @kou @assignUser

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Thanks!

@kou kou merged commit e2ddf1c into apache:main Apr 11, 2023
@kou
Copy link
Member

kou commented Apr 11, 2023

@github-actions crossbow submit test-conda-python-3.10

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels Apr 11, 2023
@github-actions
Copy link

Revision: 30da1a6

Submitted crossbow builds: ursacomputing/crossbow @ actions-a134c9ccc6

Task Status
test-conda-python-3.10 Github Actions

@ursabot
Copy link

ursabot commented Apr 11, 2023

Benchmark runs are scheduled for baseline = 0cf4ffa and contender = e2ddf1c. e2ddf1c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.44% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.51% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.49% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] e2ddf1c5 ec2-t3-xlarge-us-east-2
[Finished] e2ddf1c5 test-mac-arm
[Finished] e2ddf1c5 ursa-i9-9960x
[Finished] e2ddf1c5 ursa-thinkcentre-m75q
[Finished] 0cf4ffaa ec2-t3-xlarge-us-east-2
[Finished] 0cf4ffaa test-mac-arm
[Finished] 0cf4ffaa ursa-i9-9960x
[Finished] 0cf4ffaa ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@h-vetinari h-vetinari deleted the deps branch April 11, 2023 12:29
@assignUser
Copy link
Member

@h-vetinari Thanks for pushing this through!

liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this pull request May 11, 2023
apache#34652)

As well as other changes that happened on the feedstock since apache#14832
* Closes: apache#34669

Lead-authored-by: H. Vetinari <h.vetinari@gmx.com>
Co-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this pull request May 15, 2023
apache#34652)

As well as other changes that happened on the feedstock since apache#14832
* Closes: apache#34669

Lead-authored-by: H. Vetinari <h.vetinari@gmx.com>
Co-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
rtpsw pushed a commit to rtpsw/arrow that referenced this pull request May 16, 2023
apache#34652)

As well as other changes that happened on the feedstock since apache#14832
* Closes: apache#34669

Lead-authored-by: H. Vetinari <h.vetinari@gmx.com>
Co-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting merge Awaiting merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Packaging][Conda] Sync with conda-forge feedstock
6 participants