-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-34669: [Packaging][Conda] Update arrow feedstock dependencies #34652
Conversation
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format?
or
In the case of PARQUET issues on JIRA the title also supports:
See also: |
@github-actions crossbow submit -g conda |
Revision: ed78d6a Submitted crossbow builds: ursacomputing/crossbow @ actions-3363969e3b |
@github-actions crossbow submit -g conda |
Revision: fead3ed Submitted crossbow builds: ursacomputing/crossbow @ actions-2def4fe972 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you open an issue for this pull request and associate it with this pull request?
else() | ||
set(ARROW_GDB_AUTO_LOAD_LIBARROW_GDB_DIR | ||
- "${ARROW_GDB_AUTO_LOAD_DIR}/${CMAKE_INSTALL_FULL_LIBDIR}") | ||
+ "${ARROW_GDB_AUTO_LOAD_DIR}/replace_this_section_with_absolute_slashed_path_to_CONDA_PREFIX/lib/") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you open an issue for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done: #34670
|
Done. |
@github-actions crossbow submit -g conda |
Revision: d55f2d4 Submitted crossbow builds: ursacomputing/crossbow @ actions-7bc0e8ac31 |
Thanks a lot for your work on the arrow feedstocks here and on conda-forge @h-vetinari ! Does this sync changes from the conda-forge feedstock into the arrow repo or will these changes also be used by the upstream repo? |
I sync both ways. All the changes here originated on the feedstock, though I saw that there was one change here that removed a build option, which I'll mirror back to the feedstock as soon as arrow 12 is released. |
Ah great, thanks again. I don't think we have any documentation about the whole process of syncing and maintaining the conda-forge feedstock other than a small checkbox as a post-release task... do you think it would make sense to document the process to make it easier for the rest of the community to aid in this process? |
I've been piecing things together myself as well, but I do have a bunch of experience from the conda-forge side. I could write something up - could you tell me where that should go? |
Oh great! I think that would be best located in the post release task section of the release management guide: https://github.com/apache/arrow/blob/main/docs/source/developers/release.rst |
@github-actions crossbow submit -g conda |
Revision: cbd13db Submitted crossbow builds: ursacomputing/crossbow @ actions-60f7fe1922 |
Could you rebase on the current main for R errors? |
@github-actions crossbow submit -g conda |
Revision: 40180fe Submitted crossbow builds: ursacomputing/crossbow @ actions-e13c3a337a |
Still fails with the acero errors for R on windows... |
Possibly. I'd just switch off running the test suite for the builds running in emulation TBH. |
@github-actions crossbow submit -g conda |
Revision: 30da1a6 Submitted crossbow builds: ursacomputing/crossbow @ actions-e39652519d |
This is now passing except R on windows. CC @kou @assignUser |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Thanks!
@github-actions crossbow submit test-conda-python-3.10 |
Revision: 30da1a6 Submitted crossbow builds: ursacomputing/crossbow @ actions-a134c9ccc6
|
Benchmark runs are scheduled for baseline = 0cf4ffa and contender = e2ddf1c. e2ddf1c is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
@h-vetinari Thanks for pushing this through! |
apache#34652) As well as other changes that happened on the feedstock since apache#14832 * Closes: apache#34669 Lead-authored-by: H. Vetinari <h.vetinari@gmx.com> Co-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
apache#34652) As well as other changes that happened on the feedstock since apache#14832 * Closes: apache#34669 Lead-authored-by: H. Vetinari <h.vetinari@gmx.com> Co-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
apache#34652) As well as other changes that happened on the feedstock since apache#14832 * Closes: apache#34669 Lead-authored-by: H. Vetinari <h.vetinari@gmx.com> Co-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
As well as other changes that happened on the feedstock since #14832