Skip to content

GH-15070: [Python][CI] Compatibility with pandas 2.0 #34878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2023
Merged

GH-15070: [Python][CI] Compatibility with pandas 2.0 #34878

merged 1 commit into from
Apr 4, 2023

Conversation

jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented Apr 4, 2023 •
edited by github-actions bot
Loading

What changes are included in this PR?

Are there any user-facing changes?

No

@github-actions
Copy link

github-actions bot commented Apr 4, 2023

@jorisvandenbossche
Copy link
Member Author

@github-actions crossbow submit test-conda-python-3.8-pandas-nightly test-conda-python-3.9-pandas-upstream_devel

@github-actions
Copy link

github-actions bot commented Apr 4, 2023

Revision: b5549d3

Submitted crossbow builds: ursacomputing/crossbow @ actions-7ff36ba325

Task Status
test-conda-python-3.8-pandas-nightly Github Actions
test-conda-python-3.9-pandas-upstream_devel Github Actions

@jorisvandenbossche jorisvandenbossche merged commit c4057bd into apache:main Apr 4, 2023
@jorisvandenbossche jorisvandenbossche deleted the compat-pandas-20 branch April 4, 2023 14:43
@ursabot
Copy link

ursabot commented Apr 5, 2023

Benchmark runs are scheduled for baseline = a84a39b and contender = c4057bd. c4057bd is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.26% ⬆️0.0%] ursa-i9-9960x
[Failed ⬇️0.0% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] c4057bd0 ec2-t3-xlarge-us-east-2
[Failed] c4057bd0 test-mac-arm
[Finished] c4057bd0 ursa-i9-9960x
[Failed] c4057bd0 ursa-thinkcentre-m75q
[Finished] a84a39b6 ec2-t3-xlarge-us-east-2
[Failed] a84a39b6 test-mac-arm
[Finished] a84a39b6 ursa-i9-9960x
[Failed] a84a39b6 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@h-vetinari h-vetinari mentioned this pull request Apr 15, 2023
Closed
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this pull request May 15, 2023
@jorisvandenbossche @ArgusLi
apacheGH-15070: [Python][CI] Compatibility with pandas 2.0 (apache#34878
ee67c84 
)

### What changes are included in this PR?

- The issue with numpy 1.25 in the assert equal helper was fixed in pandas 1.5.3 -> removing the skip (in theory can still run into this error when using an older pandas version with the latest numpy, but that's not something you should do)
- Casting tz-aware strings to datetime64[ns] was not fixed in pandas (pandas-dev/pandas#50140) -> updating our implementation to work around it
- Casting to numpy string dtype (pandas-dev/pandas#50127) is not yet fixed -> updating the skip

### Are there any user-facing changes?

No
* Closes: apache#15070

Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
rtpsw pushed a commit to rtpsw/arrow that referenced this pull request May 16, 2023
@jorisvandenbossche @rtpsw
apacheGH-15070: [Python][CI] Compatibility with pandas 2.0 (apache#34878
23793b1 
)

### What changes are included in this PR?

- The issue with numpy 1.25 in the assert equal helper was fixed in pandas 1.5.3 -> removing the skip (in theory can still run into this error when using an older pandas version with the latest numpy, but that's not something you should do)
- Casting tz-aware strings to datetime64[ns] was not fixed in pandas (pandas-dev/pandas#50140) -> updating our implementation to work around it
- Casting to numpy string dtype (pandas-dev/pandas#50127) is not yet fixed -> updating the skip

### Are there any user-facing changes?

No
* Closes: apache#15070

Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@csubhodeep csubhodeep mentioned this pull request May 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlenkaF AlenkaF AlenkaF approved these changes

Assignees
No one assigned
Labels
awaiting committer review Awaiting committer review Component: Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Python][CI] Compatibility with pandas 2.0
3 participants
@jorisvandenbossche @ursabot @AlenkaF