Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-36513: [Dev][C#] Add Dependabot configuration for NuGet #36514

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

kou
Copy link
Member

@kou kou commented Jul 6, 2023

Rationale for this change

We don't want to adjust PR titles from Dependabot manually.

What changes are included in this PR?

Set the commit message prefix for /csharp/ from Dependabot.

Are these changes tested?

No. I hope that this works well...

Are there any user-facing changes?

No.

@kou kou requested review from assignUser and raulcd as code owners July 6, 2023 20:37
@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Jul 6, 2023
@github-actions
Copy link

github-actions bot commented Jul 6, 2023

⚠️ GitHub issue #36513 has been automatically assigned in GitHub to PR creator.

Copy link
Member

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@assignUser assignUser merged commit 3cd816c into apache:main Jul 7, 2023
@assignUser assignUser removed the awaiting committer review Awaiting committer review label Jul 7, 2023
@kou kou deleted the dependabot-nuget branch July 7, 2023 01:19
@eerhardt
Copy link
Contributor

eerhardt commented Jul 7, 2023

Are they useful for us? Or should we revert this configuration?

Some are useful. But some I would suggest not to take. For example #36530.

I would suggest adding this section:

https://github.com/microsoft/semantic-kernel/blob/8d705b30adf0ef94792dacb86424b172b613ffcd/.github/dependabot.yml#L25-L31

For things like System., Microsoft.Bcl., etc. we want to consciously upgrade major versions. There are reasons why customers want to stay on older versions, for example 6.0 which is "LTS - long term support", and not upgrade to 7.0, which goes out of support sooner than 6.0.

See microsoft/semantic-kernel#1799 for reasoning why staying on lower major versions is preferred in some cases.

@kou
Copy link
Member Author

kou commented Jul 9, 2023

OK. I've opened #36577. Could you review PRs from Dependabot and merge/close them?

@conbench-apache-arrow
Copy link

Conbench analyzed the 6 benchmark runs on commit 3cd816c5.

There was 1 benchmark result indicating a performance regression:

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dev][C#] Add Dependabot configuration for NuGet
3 participants