GH-36687: [R] Add correct branch name to autobrew formulae to facilitate local testing #36689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: R
awaiting committer review
raulcd
pushed a commit
that referenced
this pull request
Jul 18, 2023
…ate local testing (#36689) ### Rationale for this change It is currently not possible to recreate an autobrew build locally by following the instructions in the comments. This fixes the local copies of the upstream formulas and the instructions so that future debuggers can recreate an autobrew build. ### What changes are included in this PR? The branch `master` no longer exists and is the default value. This PR adds the revised default branch name ("main"). ### Are these changes tested? No nightly test covers this because this value would be overwritten to test specific commits anyway. ### Are there any user-facing changes? No. * Closes: #36687 Authored-by: Dewey Dunnington <dewey@voltrondata.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
chelseajonesr
pushed a commit
to chelseajonesr/arrow
that referenced
this pull request
Jul 20, 2023
…acilitate local testing (apache#36689) ### Rationale for this change It is currently not possible to recreate an autobrew build locally by following the instructions in the comments. This fixes the local copies of the upstream formulas and the instructions so that future debuggers can recreate an autobrew build. ### What changes are included in this PR? The branch `master` no longer exists and is the default value. This PR adds the revised default branch name ("main"). ### Are these changes tested? No nightly test covers this because this value would be overwritten to test specific commits anyway. ### Are there any user-facing changes? No. * Closes: apache#36687 Authored-by: Dewey Dunnington <dewey@voltrondata.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 1bee643. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
R-JunmingChen
pushed a commit
to R-JunmingChen/arrow
that referenced
this pull request
Aug 20, 2023
…acilitate local testing (apache#36689) ### Rationale for this change It is currently not possible to recreate an autobrew build locally by following the instructions in the comments. This fixes the local copies of the upstream formulas and the instructions so that future debuggers can recreate an autobrew build. ### What changes are included in this PR? The branch `master` no longer exists and is the default value. This PR adds the revised default branch name ("main"). ### Are these changes tested? No nightly test covers this because this value would be overwritten to test specific commits anyway. ### Are there any user-facing changes? No. * Closes: apache#36687 Authored-by: Dewey Dunnington <dewey@voltrondata.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
It is currently not possible to recreate an autobrew build locally by following the instructions in the comments. This fixes the local copies of the upstream formulas and the instructions so that future debuggers can recreate an autobrew build.
What changes are included in this PR?
The branch
masterno longer exists and is the default value. This PR adds the revised default branch name ("main").Are these changes tested?
No nightly test covers this because this value would be overwritten to test specific commits anyway.
Are there any user-facing changes?
No.
branch: "main"preventing local autobrew testing #36687