Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-36692: [CI][Packaging] Pin gemfury to 0.12.0 due to issue with faraday dependency #36693

Merged
merged 16 commits into from
Aug 1, 2023

Conversation

raulcd
Copy link
Member

@raulcd raulcd commented Jul 14, 2023

Rationale for this change

Some nightly wheel jobs have failed to upload.

What changes are included in this PR?

Install required gem dependency.

Are these changes tested?

Yes, crossbow tasks

Are there any user-facing changes?

No

@raulcd
Copy link
Member Author

raulcd commented Jul 14, 2023

@github-actions crossbow submit -g wheel

@github-actions
Copy link

⚠️ GitHub issue #36692 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Jul 14, 2023
@github-actions

This comment was marked as outdated.

@raulcd
Copy link
Member Author

raulcd commented Jul 14, 2023

I've just realised the previous jobs won't fail because we check the branch is the default branch. I'll temporarily remove the check and resubmit the jobs again.

@raulcd
Copy link
Member Author

raulcd commented Jul 14, 2023

@github-actions crossbow submit -g wheel

@github-actions

This comment was marked as outdated.

@raulcd
Copy link
Member Author

raulcd commented Jul 14, 2023

I am confused because this PR was triggered yesterday without this change and the wheels jobs worked: #36657

@kou
Copy link
Member

kou commented Jul 14, 2023

It seems that gemfury 0.12.1 was released yesterday :-)
https://rubygems.org/gems/gemfury/versions/0.12.1

@kou
Copy link
Member

kou commented Jul 14, 2023

Another approach (ensure using recent Ruby):

diff --git a/dev/tasks/macros.jinja b/dev/tasks/macros.jinja
index 4c65a64c8..a879dcb67 100644
--- a/dev/tasks/macros.jinja
+++ b/dev/tasks/macros.jinja
@@ -137,6 +137,11 @@ on:
     run: |
       sudo apt update
       sudo apt install -y ruby-full
+  - name: Set up Ruby by GitHub Actions
+    if: !(runner.os == 'Linux' && runner.arch != 'X64')
+    use: ruby/setup-ruby@1
+    with:
+      ruby-version: "ruby"
   - name: Upload package to Gemfury
     shell: bash
     run: |

@raulcd
Copy link
Member Author

raulcd commented Jul 15, 2023

@github-actions crossbow submit -g wheel

@github-actions

This comment was marked as outdated.

@kou
Copy link
Member

kou commented Jul 15, 2023

@github-actions crossbow submit -g wheel

@github-actions

This comment was marked as outdated.

dev/tasks/macros.jinja Outdated Show resolved Hide resolved
@kou
Copy link
Member

kou commented Jul 15, 2023

@github-actions crossbow submit -g wheel

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Jul 15, 2023
@github-actions

This comment was marked as outdated.

dev/tasks/macros.jinja Outdated Show resolved Hide resolved
@kou
Copy link
Member

kou commented Jul 16, 2023

@github-actions crossbow submit -g wheel

@github-actions github-actions bot added awaiting change review Awaiting change review awaiting changes Awaiting changes and removed awaiting changes Awaiting changes awaiting change review Awaiting change review labels Jul 16, 2023
@github-actions

This comment was marked as outdated.

dev/tasks/macros.jinja Outdated Show resolved Hide resolved
@kou
Copy link
Member

kou commented Jul 16, 2023

@github-actions crossbow submit -g wheel

@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Jul 16, 2023
@raulcd
Copy link
Member Author

raulcd commented Jul 31, 2023

@github-actions crossbow submit -g wheel

@github-actions

This comment was marked as outdated.

@raulcd
Copy link
Member Author

raulcd commented Jul 31, 2023

@github-actions crossbow submit wheel-macos-big-sur-cp311-arm64

@github-actions
Copy link

Revision: a1c2591

Submitted crossbow builds: ursacomputing/crossbow @ actions-fdb072a9e2

Task Status
wheel-macos-big-sur-cp311-arm64 Github Actions

@raulcd
Copy link
Member Author

raulcd commented Jul 31, 2023

@github-actions crossbow submit -g wheel

@github-actions
Copy link

Revision: a1c2591

Submitted crossbow builds: ursacomputing/crossbow @ actions-dbef27b825

Task Status
wheel-clean Github Actions
wheel-macos-big-sur-cp310-arm64 Github Actions
wheel-macos-big-sur-cp311-arm64 Github Actions
wheel-macos-big-sur-cp38-arm64 Github Actions
wheel-macos-big-sur-cp39-arm64 Github Actions
wheel-macos-mojave-cp310-amd64 Github Actions
wheel-macos-mojave-cp311-amd64 Github Actions
wheel-macos-mojave-cp38-amd64 Github Actions
wheel-macos-mojave-cp39-amd64 Github Actions
wheel-manylinux-2-28-cp310-amd64 Github Actions
wheel-manylinux-2-28-cp310-arm64 Github Actions
wheel-manylinux-2-28-cp311-amd64 Github Actions
wheel-manylinux-2-28-cp311-arm64 Github Actions
wheel-manylinux-2-28-cp38-amd64 Github Actions
wheel-manylinux-2-28-cp38-arm64 Github Actions
wheel-manylinux-2-28-cp39-amd64 Github Actions
wheel-manylinux-2-28-cp39-arm64 Github Actions
wheel-manylinux-2014-cp310-amd64 Github Actions
wheel-manylinux-2014-cp310-arm64 Github Actions
wheel-manylinux-2014-cp311-amd64 Github Actions
wheel-manylinux-2014-cp311-arm64 Github Actions
wheel-manylinux-2014-cp38-amd64 Github Actions
wheel-manylinux-2014-cp38-arm64 Github Actions
wheel-manylinux-2014-cp39-amd64 Github Actions
wheel-manylinux-2014-cp39-arm64 Github Actions
wheel-windows-cp310-amd64 Github Actions
wheel-windows-cp311-amd64 Github Actions
wheel-windows-cp38-amd64 Github Actions
wheel-windows-cp39-amd64 Github Actions

@raulcd raulcd marked this pull request as ready for review July 31, 2023 17:04
@raulcd raulcd requested a review from assignUser as a code owner July 31, 2023 17:04
@raulcd
Copy link
Member Author

raulcd commented Jul 31, 2023

@kou this should be good to review now. All wheels have been uploaded successfully.

@raulcd raulcd changed the title GH-36692: [CI][Packaging] Install required faraday gem to push wheels GH-36692: [CI][Packaging] Pin gemfury to 0.12.0 due to issue with faraday dependency Jul 31, 2023
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

dev/tasks/macros.jinja Outdated Show resolved Hide resolved
@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels Jul 31, 2023
@raulcd
Copy link
Member Author

raulcd commented Aug 1, 2023

@github-actions crossbow submit -g wheel

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting merge Awaiting merge labels Aug 1, 2023
@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Revision: 07e6190

Submitted crossbow builds: ursacomputing/crossbow @ actions-829044b7db

Task Status
wheel-clean Github Actions
wheel-macos-big-sur-cp310-arm64 Github Actions
wheel-macos-big-sur-cp311-arm64 Github Actions
wheel-macos-big-sur-cp38-arm64 Github Actions
wheel-macos-big-sur-cp39-arm64 Github Actions
wheel-macos-mojave-cp310-amd64 Github Actions
wheel-macos-mojave-cp311-amd64 Github Actions
wheel-macos-mojave-cp38-amd64 Github Actions
wheel-macos-mojave-cp39-amd64 Github Actions
wheel-manylinux-2-28-cp310-amd64 Github Actions
wheel-manylinux-2-28-cp310-arm64 Github Actions
wheel-manylinux-2-28-cp311-amd64 Github Actions
wheel-manylinux-2-28-cp311-arm64 Github Actions
wheel-manylinux-2-28-cp38-amd64 Github Actions
wheel-manylinux-2-28-cp38-arm64 Github Actions
wheel-manylinux-2-28-cp39-amd64 Github Actions
wheel-manylinux-2-28-cp39-arm64 Github Actions
wheel-manylinux-2014-cp310-amd64 Github Actions
wheel-manylinux-2014-cp310-arm64 Github Actions
wheel-manylinux-2014-cp311-amd64 Github Actions
wheel-manylinux-2014-cp311-arm64 Github Actions
wheel-manylinux-2014-cp38-amd64 Github Actions
wheel-manylinux-2014-cp38-arm64 Github Actions
wheel-manylinux-2014-cp39-amd64 Github Actions
wheel-manylinux-2014-cp39-arm64 Github Actions
wheel-windows-cp310-amd64 Github Actions
wheel-windows-cp311-amd64 Github Actions
wheel-windows-cp38-amd64 Github Actions
wheel-windows-cp39-amd64 Github Actions

@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Aug 1, 2023
@raulcd raulcd merged commit 943bf48 into apache:main Aug 1, 2023
7 checks passed
@raulcd raulcd removed the awaiting change review Awaiting change review label Aug 1, 2023
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 943bf48.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.

loicalleyne pushed a commit to loicalleyne/arrow that referenced this pull request Nov 13, 2023
…th faraday dependency (apache#36693)

### Rationale for this change

Some nightly wheel jobs have failed to upload.

### What changes are included in this PR?

Install required gem dependency.

### Are these changes tested?

Yes, crossbow tasks

### Are there any user-facing changes?

No
* Closes: apache#36692

Lead-authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI][Packaging] gemfury client fails to update wheels on ARM64 and Windows
3 participants