-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-36692: [CI][Packaging] Pin gemfury to 0.12.0 due to issue with faraday dependency #36693
Conversation
@github-actions crossbow submit -g wheel |
|
This comment was marked as outdated.
This comment was marked as outdated.
I've just realised the previous jobs won't fail because we check the branch is the default branch. I'll temporarily remove the check and resubmit the jobs again. |
@github-actions crossbow submit -g wheel |
This comment was marked as outdated.
This comment was marked as outdated.
I am confused because this PR was triggered yesterday without this change and the wheels jobs worked: #36657 |
It seems that gemfury 0.12.1 was released yesterday :-) |
Another approach (ensure using recent Ruby): diff --git a/dev/tasks/macros.jinja b/dev/tasks/macros.jinja
index 4c65a64c8..a879dcb67 100644
--- a/dev/tasks/macros.jinja
+++ b/dev/tasks/macros.jinja
@@ -137,6 +137,11 @@ on:
run: |
sudo apt update
sudo apt install -y ruby-full
+ - name: Set up Ruby by GitHub Actions
+ if: !(runner.os == 'Linux' && runner.arch != 'X64')
+ use: ruby/setup-ruby@1
+ with:
+ ruby-version: "ruby"
- name: Upload package to Gemfury
shell: bash
run: | |
@github-actions crossbow submit -g wheel |
This comment was marked as outdated.
This comment was marked as outdated.
@github-actions crossbow submit -g wheel |
This comment was marked as outdated.
This comment was marked as outdated.
@github-actions crossbow submit -g wheel |
This comment was marked as outdated.
This comment was marked as outdated.
@github-actions crossbow submit -g wheel |
This comment was marked as outdated.
This comment was marked as outdated.
@github-actions crossbow submit -g wheel |
@github-actions crossbow submit -g wheel |
This comment was marked as outdated.
This comment was marked as outdated.
@github-actions crossbow submit wheel-macos-big-sur-cp311-arm64 |
Revision: a1c2591 Submitted crossbow builds: ursacomputing/crossbow @ actions-fdb072a9e2
|
@github-actions crossbow submit -g wheel |
Revision: a1c2591 Submitted crossbow builds: ursacomputing/crossbow @ actions-dbef27b825 |
@kou this should be good to review now. All wheels have been uploaded successfully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
@github-actions crossbow submit -g wheel |
Revision: 07e6190 Submitted crossbow builds: ursacomputing/crossbow @ actions-829044b7db |
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 943bf48. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them. |
…th faraday dependency (apache#36693) ### Rationale for this change Some nightly wheel jobs have failed to upload. ### What changes are included in this PR? Install required gem dependency. ### Are these changes tested? Yes, crossbow tasks ### Are there any user-facing changes? No * Closes: apache#36692 Lead-authored-by: Raúl Cumplido <raulcumplido@gmail.com> Co-authored-by: Sutou Kouhei <kou@cozmixng.org> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
Rationale for this change
Some nightly wheel jobs have failed to upload.
What changes are included in this PR?
Install required gem dependency.
Are these changes tested?
Yes, crossbow tasks
Are there any user-facing changes?
No