Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-36816: [C#] Reduce allocations #36817

Merged
merged 3 commits into from
Aug 18, 2023

Conversation

CurtHagenlocher
Copy link
Contributor

@CurtHagenlocher CurtHagenlocher commented Jul 21, 2023

What changes are included in this PR?

A small refactoring to make a small improvement in memory utilization.

Are these changes tested?

Existing test coverage should be sufficient.

@github-actions
Copy link

⚠️ GitHub issue #36816 has been automatically assigned in GitHub to PR creator.

Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Aug 18, 2023
@lidavidm lidavidm merged commit 4fa6719 into apache:main Aug 18, 2023
9 checks passed
@lidavidm lidavidm removed the awaiting merge Awaiting merge label Aug 18, 2023
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 4fa6719.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.

@CurtHagenlocher CurtHagenlocher deleted the ReduceAllocations branch September 25, 2023 13:19
loicalleyne pushed a commit to loicalleyne/arrow that referenced this pull request Nov 13, 2023
### What changes are included in this PR?

A small refactoring to make a small improvement in memory utilization.

### Are these changes tested?

Existing test coverage should be sufficient.

* Closes: apache#36816

Authored-by: Curt Hagenlocher <curt@hagenlocher.org>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[C#] There's no need to create multiple TimeType or IntervalType objects
2 participants