Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-36815: [C#]: Enable net472 tests under Windows #36818

Merged
merged 4 commits into from
Oct 17, 2023
Merged

GH-36815: [C#]: Enable net472 tests under Windows #36818

merged 4 commits into from
Oct 17, 2023

Conversation

CurtHagenlocher
Copy link
Contributor

@CurtHagenlocher CurtHagenlocher commented Jul 21, 2023 •
edited by github-actions bot
Loading

What changes are included in this PR?

The primary C# test project is updated to run for .NET 4.7.2 only on Windows platforms.

Are these changes tested?

Yes.

@github-actions
Copy link

⚠️ GitHub issue #36815 has been automatically assigned in GitHub to PR creator.

@CurtHagenlocher CurtHagenlocher marked this pull request as ready for review July 21, 2023 21:09
@CurtHagenlocher
Copy link
Contributor Author

Okay, this seems to work.

@CurtHagenlocher CurtHagenlocher mentioned this pull request Jul 24, 2023
Closed
@kou
Copy link
Member

kou commented Jul 24, 2023

@github-actions crossbow submit verify-rc-source-csharp-*

@github-actions
Copy link

Revision: e81d15f

Submitted crossbow builds: ursacomputing/crossbow @ actions-0e47458a7b

Task Status
verify-rc-source-csharp-linux-almalinux-8-amd64 Github Actions
verify-rc-source-csharp-linux-conda-latest-amd64 Github Actions
verify-rc-source-csharp-linux-ubuntu-20.04-amd64 Github Actions
verify-rc-source-csharp-linux-ubuntu-22.04-amd64 Github Actions
verify-rc-source-csharp-macos-amd64 Github Actions
verify-rc-source-csharp-macos-arm64 Github Actions

@kou
Copy link
Member

kou commented Jul 25, 2023

@github-actions crossbow submit verify-rc-source-windows

@github-actions
Copy link

Revision: e81d15f

Submitted crossbow builds: ursacomputing/crossbow @ actions-3dd808a59e

Task Status
verify-rc-source-windows Github Actions

@kou
Copy link
Member

kou commented Jul 26, 2023

Ah, our RC verification script https://github.com/apache/arrow/blob/main/dev/release/verify-release-candidate.bat doesn't test the C# part...
We need to add it. Could you open an issue for it?

Does the following log show that this case was tested?

https://github.com/apache/arrow/actions/runs/5626539222/job/15247546402?pr=36818#step:6:68

Test run for D:\a\arrow\arrow\csharp\artifacts\Apache.Arrow.Tests\Debug\net472\Apache.Arrow.Tests.dll (.NETFramework,Version=v4.7.2)
Microsoft (R) Test Execution Command Line Tool Version 17.6.3 (x64)
Copyright (c) Microsoft Corporation.  All rights reserved.

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.

Passed!  - Failed:     0, Passed:  1110, Skipped:     0, Total:  1110, Duration: 5 s - Apache.Arrow.Tests.dll (net472)

@CurtHagenlocher CurtHagenlocher mentioned this pull request Oct 16, 2023
Open
@CurtHagenlocher
Copy link
Contributor Author

I clearly should have come back to this before checking in the Duration change (which has now broken the .NET 4.7.2 build).

Opened #38298.

@CurtHagenlocher
Copy link
Contributor Author

@github-actions crossbow submit verify-rc-source-windows

@github-actions
Copy link

Revision: 438632f

Submitted crossbow builds: ursacomputing/crossbow @ actions-8a2a4f68be

Task Status
verify-rc-source-windows Github Actions

@CurtHagenlocher CurtHagenlocher merged commit 4011058 into apache:main Oct 17, 2023
8 checks passed
@CurtHagenlocher CurtHagenlocher removed the awaiting review Awaiting review label Oct 17, 2023
@CurtHagenlocher CurtHagenlocher deleted the net472test branch October 17, 2023 02:56
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 4011058.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

JerAguilon pushed a commit to JerAguilon/arrow that referenced this pull request Oct 23, 2023
@CurtHagenlocher
apacheGH-36815: [C#]: Enable net472 tests under Windows (apache#36818)
3cdc288 
### What changes are included in this PR?

The primary C# test project is updated to run for .NET 4.7.2 only on Windows platforms.

### Are these changes tested?

Yes.
* Closes: apache#36815

Authored-by: Curt Hagenlocher <curt@hagenlocher.org>
Signed-off-by: Curt Hagenlocher <curt@hagenlocher.org>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this pull request Nov 13, 2023
@CurtHagenlocher @loicalleyne
apacheGH-36815: [C#]: Enable net472 tests under Windows (apache#36818)
8a6a4ab 
### What changes are included in this PR?

The primary C# test project is updated to run for .NET 4.7.2 only on Windows platforms.

### Are these changes tested?

Yes.
* Closes: apache#36815

Authored-by: Curt Hagenlocher <curt@hagenlocher.org>
Signed-off-by: Curt Hagenlocher <curt@hagenlocher.org>
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
@CurtHagenlocher @dgreiss
apacheGH-36815: [C#]: Enable net472 tests under Windows (apache#36818)
613a2b2 
### What changes are included in this PR?

The primary C# test project is updated to run for .NET 4.7.2 only on Windows platforms.

### Are these changes tested?

Yes.
* Closes: apache#36815

Authored-by: Curt Hagenlocher <curt@hagenlocher.org>
Signed-off-by: Curt Hagenlocher <curt@hagenlocher.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonpace westonpace Awaiting requested review from westonpace

Assignees
No one assigned
Labels
Component: C#
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[C#] CI should run for .NET 4.7.2 under Windows
2 participants
@CurtHagenlocher @kou