Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-15017: [Python] Harden test_memory.py for use with ARROW_USE_GLOG=ON #36901

Merged
merged 3 commits into from
Jul 28, 2023
Merged

GH-15017: [Python] Harden test_memory.py for use with ARROW_USE_GLOG=ON #36901

merged 3 commits into from
Jul 28, 2023

Conversation

h-vetinari
Copy link
Contributor

@h-vetinari h-vetinari commented Jul 27, 2023 •
edited by kou
Loading

@h-vetinari
harden test_memory.py for use with ARROW_USE_GLOG=ON
f0fbddf 
Suggested-By: Sutou Kouhei <kou@clear-code.com>
@github-actions
Copy link

⚠️ GitHub issue #15017 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting review Awaiting review label Jul 27, 2023
@h-vetinari
Copy link
Contributor Author

@github-actions crossbow submit -g conda-linux-x64-cpu-py3

@github-actions
Copy link 

Invalid group(s) {'conda-linux-x64-cpu-py3'}. Must be one of {'example-cpp', 'conda', 'test', 'homebrew', 'linux', 'fuzz', 'c-glib', 'verify-rc-source', 'ruby', 'integration', 'verify-rc-source-linux', 'verify-rc-source-macos', 'vcpkg', 'cpp', 'example', 'nightly-tests', 'linux-amd64', 'verify-rc-binaries', 'wheel', 'verify-rc-wheels', 'nightly-packaging', 'python', 'nightly', 'packaging', 'linux-arm64', 'verify-rc', 'example-python', 'conan', 'r', 'nightly-release', 'verify-rc-jars'}
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/5675632984

@h-vetinari
Copy link
Contributor Author

I don't want to run the full barrage of conda-tests here to verify that the tests passes when glog is enabled. One run of conda-{linux,osx}-x64-cpu-py3 would be enough, but I don't know how to do that with the crossbow invocation.

@kou
Copy link
Member

kou commented Jul 27, 2023

@github-actions crossbow submit conda-linux-x64-cpu-py3 conda-osx-x64-cpu-py3

@kou kou changed the title GH-15017: harden test_memory.py for use with ARROW_USE_GLOG=ON GH-15017: [Python] Harden test_memory.py for use with ARROW_USE_GLOG=ON Jul 27, 2023
@github-actions
Copy link

Revision: f0fbddf

Submitted crossbow builds: ursacomputing/crossbow @ actions-1537d49ce0

Task Status
conda-linux-x64-cpu-py3 Azure
conda-osx-x64-cpu-py3 Azure

@h-vetinari
Copy link
Contributor Author

@github-actions crossbow submit conda-linux-x64-cpu-py3 conda-osx-x64-cpu-py3

@github-actions
Copy link

Revision: 9e394b2

Submitted crossbow builds: ursacomputing/crossbow @ actions-d5c32d8073

Task Status
conda-linux-x64-cpu-py3 Azure
conda-osx-x64-cpu-py3 Azure

@h-vetinari
Copy link
Contributor Author

@kou, this should be ready IMO - at least, I couldn't find anything in the linter job that's related to this PR.

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Jul 28, 2023
kou
kou approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 47e438a into apache:main Jul 28, 2023
@kou kou removed the awaiting changes Awaiting changes label Jul 28, 2023
@github-actions github-actions bot added the awaiting merge Awaiting merge label Jul 28, 2023
@h-vetinari h-vetinari deleted the glog_test branch July 28, 2023 02:36
@h-vetinari
Copy link
Contributor Author

Thanks for fixing the superfluous f-string! :)

@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 47e438a.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.

R-JunmingChen pushed a commit to R-JunmingChen/arrow that referenced this pull request Aug 20, 2023
@h-vetinari @kou @R-JunmingChen
apacheGH-15017: [Python] Harden test_memory.py for use with ARROW_USE…
4e05b44 
…_GLOG=ON (apache#36901)

Accept output pattern for ARROW_USE_GLOG=ON too.

* Closes: apache#15017

Lead-authored-by: H. Vetinari <h.vetinari@gmx.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this pull request Nov 13, 2023
@h-vetinari @kou @loicalleyne
apacheGH-15017: [Python] Harden test_memory.py for use with ARROW_USE…
43ace75 
…_GLOG=ON (apache#36901)

Accept output pattern for ARROW_USE_GLOG=ON too.

* Closes: apache#15017

Lead-authored-by: H. Vetinari <h.vetinari@gmx.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kou kou kou approved these changes

@assignUser assignUser Awaiting requested review from assignUser assignUser is a code owner

@raulcd raulcd Awaiting requested review from raulcd raulcd is a code owner

Assignees
No one assigned
Labels
awaiting merge Awaiting merge Component: Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Python] BUG: two failing tests related to ARROW_DEFAULT_MEMORY_POOL in conda builds on unix
2 participants
@h-vetinari @kou