MINOR: [C++] Fix a typo in Acero agg description #37031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kou
changed the title
kou
added a commit
that referenced
this pull request
Aug 8, 2023
### Rationale for this change GH-37031 had the following lint failure but I merged it. Sorry. ```text FAILED: CMakeFiles/check-format cd /tmp/arrow-lint-3lmfc4qt/cpp-build && /usr/local/bin/python /arrow/cpp/build-support/run_clang_format.py --clang_format_binary /usr/bin/clang-format-14 --exclude_globs /arrow/cpp/build-support/lint_exclusions.txt --source_dir /arrow/cpp/src --source_dir /arrow/cpp/examples --source_dir /arrow/cpp/tools --quiet --- /arrow/cpp/src/arrow/acero/aggregate_internal.h +++ /arrow/cpp/src/arrow/acero/aggregate_internal.h (after clang format) @@ -52,8 +52,8 @@ // segment-keys is used to refine the partitioning. However, segment-keys are different in // that they partition only consecutive rows into a single group. Such a partition of // consecutive rows is called a segment group. For example, consider a column X with -// values [A, A, B, A] at row-indices [0, 1, 2, 3]. A regular group-by aggregation with keys -// [X] yields a row-index partitioning [[0, 1, 3], [2]] whereas a segmented-group-by +// values [A, A, B, A] at row-indices [0, 1, 2, 3]. A regular group-by aggregation with +// keys [X] yields a row-index partitioning [[0, 1, 3], [2]] whereas a segmented-group-by // aggregation with segment-keys [X] yields [[0, 1], [2], [3]]. // // The implementation first segments the input using the segment-keys, then groups by the /arrow/cpp/src/arrow/acero/aggregate_internal.h had clang-format style issues ``` ### What changes are included in this PR? I've fixed it by `ninja format`. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 3bb13da. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them. |
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
### Rationale for this change ### What changes are included in this PR? fix acero agg node typo ### Are these changes tested? ### Are there any user-facing changes? Authored-by: SGZW <shuguangzw@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
### Rationale for this change apacheGH-37031 had the following lint failure but I merged it. Sorry. ```text FAILED: CMakeFiles/check-format cd /tmp/arrow-lint-3lmfc4qt/cpp-build && /usr/local/bin/python /arrow/cpp/build-support/run_clang_format.py --clang_format_binary /usr/bin/clang-format-14 --exclude_globs /arrow/cpp/build-support/lint_exclusions.txt --source_dir /arrow/cpp/src --source_dir /arrow/cpp/examples --source_dir /arrow/cpp/tools --quiet --- /arrow/cpp/src/arrow/acero/aggregate_internal.h +++ /arrow/cpp/src/arrow/acero/aggregate_internal.h (after clang format) @@ -52,8 +52,8 @@ // segment-keys is used to refine the partitioning. However, segment-keys are different in // that they partition only consecutive rows into a single group. Such a partition of // consecutive rows is called a segment group. For example, consider a column X with -// values [A, A, B, A] at row-indices [0, 1, 2, 3]. A regular group-by aggregation with keys -// [X] yields a row-index partitioning [[0, 1, 3], [2]] whereas a segmented-group-by +// values [A, A, B, A] at row-indices [0, 1, 2, 3]. A regular group-by aggregation with +// keys [X] yields a row-index partitioning [[0, 1, 3], [2]] whereas a segmented-group-by // aggregation with segment-keys [X] yields [[0, 1], [2], [3]]. // // The implementation first segments the input using the segment-keys, then groups by the /arrow/cpp/src/arrow/acero/aggregate_internal.h had clang-format style issues ``` ### What changes are included in this PR? I've fixed it by `ninja format`. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
What changes are included in this PR?
fix acero agg node typo
Are these changes tested?
Are there any user-facing changes?