Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-37067: [CI][C++] Use system GoogleTest on Debian 11/Ubuntu 22.04 #37084

Closed
wants to merge 1 commit into from

Conversation

kou
Copy link
Member

@kou kou commented Aug 9, 2023

Rationale for this change

It reduces build time and avoids run-time library load path problem.

What changes are included in this PR?

Use system GoogleTest instead of bundled one.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

⚠️ GitHub issue #37067 has been automatically assigned in GitHub to PR creator.

@kou kou force-pushed the ci-debian-ubuntu-use-system-gtest branch from 5cb673e to 2eb8473 Compare August 9, 2023 05:06
@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Aug 9, 2023
@kou
Copy link
Member Author

kou commented Aug 9, 2023

@github-actions crossbow submit test-debian-11-* test-ubuntu-22.04-*

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Revision: 2eb8473

Submitted crossbow builds: ursacomputing/crossbow @ actions-1d1c5c49fe

Task Status
test-debian-11-cpp-amd64 Github Actions
test-debian-11-cpp-i386 Github Actions
test-debian-11-go-1.17 Azure
test-debian-11-go-1.20 Azure
test-debian-11-python-3 Azure
test-ubuntu-22.04-cpp Github Actions
test-ubuntu-22.04-cpp-20 Github Actions
test-ubuntu-22.04-cpp-no-threading Github Actions
test-ubuntu-22.04-docs Github Actions
test-ubuntu-22.04-python-3 Github Actions

@pitrou
Copy link
Member

pitrou commented Aug 9, 2023

Isn't that punting away the problem? It seems that bundled GTest/GMock doesn't work the way it should.

@kou
Copy link
Member Author

kou commented Aug 31, 2023

You're right.
This is not a real fix.

@kou kou closed this Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting committer review Awaiting committer review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[C++][CI] Flight tests fail running on some configurations
2 participants