-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-33749: [Ruby] Add Arrow::RecordBatch#each_raw_record #37137
Merged
Merged
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
8dd6ff6
[Ruby] Add Arrow::Table#each_raw_record for iterable raw record access
otegami 3318abc
Introduce RawRecordProducer for specialized row-wise processing
otegami d3e5f3f
Refactor RawRecordsProducer for Row-Wise Processing in raw-records.cpp
otegami 93adaac
Add EachRawRecordBasicArraysTest#test_boolean
otegami a16c4c4
Add the additonal test cases about the other data types to EachRawRec…
otegami b354011
Implemented RecordBatch#each_raw_record
otegami 92b4b76
Fix typo test_tring -> test_string
otegami 66ea580
Avoid needless reference count increment
otegami b0731a7
Refactor n_columns definition in produce methods
otegami 34b53e0
Support multi-chunk ArrowTable structures for RawRecordsProducer#produce
otegami 8305926
Initialized all member variables
otegami c0a07e2
Update data retrieval logic to handle varying chunk layouts
otegami 1089b8c
Add empty chunk test case for the edge case
otegami 97ff172
Refactor: Make number of columns and rows constants
otegami 98a3599
Add test cases about dense union arrays
otegami 516ef62
Add test cases about dictionary arrays
otegami 7050dcc
Add test cases about list arrays
otegami 72cc0b4
Add test cases about map arrays
otegami 4456002
Add test cases about multiple columns
otegami e1e1cd2
Add test cases about sparse union arrays
otegami c7f4135
Add test cases about struct arrays
otegami 595f0c9
Add test cases about table
otegami 3f173ff
Improved the test case for multiple columns
otegami File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about creating
RawRecordProducer
instead of adding a new "produce" mode toRawRecordsBuilder
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix: 3318abc
Sounds pretty nice to me!
I tried to split
RawRecordProducer
into its own source file because some methods had to know the row-wise processing situation.What do you think of it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I should have written
RawRecordsProducer
notRawRecordProducer
because it produces multiple raw records.So I think that we can still use
raw-records.cpp
instead ofraw-record.cpp
because it also handles multiple raw records not just one raw record.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix: d3e5f3f