GH-37410: [C++][Gandiva] Add support for using LLVM shared library #37412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: C++
awaiting committer review
|
@github-actions crossbow submit java-jars -g wheel |
|
Revision: 5117655 Submitted crossbow builds: ursacomputing/crossbow @ actions-63e615699a
|
kou
force-pushed
the
cpp-gandiva-llvm-shared
branch
from
5117655 to
f42ae12
Compare
kou
force-pushed
the
cpp-gandiva-llvm-shared
branch
from
f42ae12 to
780357c
Compare
|
@github-actions crossbow submit -g cpp |
|
Revision: 780357c Submitted crossbow builds: ursacomputing/crossbow @ actions-3d4f488389
|
|
I'll merge this in this week if nobody objects this. |
|
+1. Thanks! |
pitrou
reviewed
Aug 31, 2023
| if(MSVC) | ||
| # It seems that conda's llvmdev for Windows doesn't provide shared | ||
| # library. | ||
| set(ARROW_LLVM_USE_SHARED_DEFAULT OFF) |
There was a problem hiding this comment.
Hmm, I don't think we should change this for conda. Instead, conda users on Windows will have to explicitly pass -DARROW_LLVM_USE_SHARED=OFF.
There was a problem hiding this comment.
It seems that LLVM itself doesn't support shared library with MSVC: https://github.com/llvm/llvm-project/blob/main/llvm/tools/llvm-shlib/CMakeLists.txt#L14-L16
github-actions
bot
added
awaiting changes
kou
commented
Sep 1, 2023
github-actions
bot
added
awaiting change review
|
@github-actions crossbow submit -g linux |
|
Revision: 52caff9 Submitted crossbow builds: ursacomputing/crossbow @ actions-e8c648a76a
|
|
+1 |
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 3ad2d0c. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them. |
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…ary (apache#37412) ### Rationale for this change Gandiva always links LLVM statically. But we can use LLVM shared library instead to reduce `libgandiva.so` size. ### What changes are included in this PR? Add `ARROW_LLVM_USE_SHARED` like other dependencies. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. This has a backward incompatible change. LLVM shared library not static libraries is used by default. If you want to use LLVM static libraries, you need to specify `-DARROW_LLVM_USE_SHARED=OFF` or `-DARROW_DEPENDENCY_USE_SHARED=OFF` explicitly. * Closes: apache#37410 Lead-authored-by: Sutou Kouhei <kou@clear-code.com> Co-authored-by: Sutou Kouhei <kou@cozmixng.org> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…ary (apache#37412) ### Rationale for this change Gandiva always links LLVM statically. But we can use LLVM shared library instead to reduce `libgandiva.so` size. ### What changes are included in this PR? Add `ARROW_LLVM_USE_SHARED` like other dependencies. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. This has a backward incompatible change. LLVM shared library not static libraries is used by default. If you want to use LLVM static libraries, you need to specify `-DARROW_LLVM_USE_SHARED=OFF` or `-DARROW_DEPENDENCY_USE_SHARED=OFF` explicitly. * Closes: apache#37410 Lead-authored-by: Sutou Kouhei <kou@clear-code.com> Co-authored-by: Sutou Kouhei <kou@cozmixng.org> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Gandiva always links LLVM statically. But we can use LLVM shared library instead to reduce
libgandiva.sosize.What changes are included in this PR?
Add
ARROW_LLVM_USE_SHAREDlike other dependencies.Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.
This has a backward incompatible change. LLVM shared library not static libraries is used by default. If you want to use LLVM static libraries, you need to specify
-DARROW_LLVM_USE_SHARED=OFFor-DARROW_DEPENDENCY_USE_SHARED=OFFexplicitly.