GH-34315: [C++] Correct is_null kernel for Union and RunEndEncoded logical nulls #37642
+153
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ded logical nulls
Co-authored-by: Weston Pace <weston.pace@gmail.com>
Co-authored-by: Weston Pace <weston.pace@gmail.com>
github-actions
bot
added
Component: C++
Component: Python
awaiting review
bkietz
reviewed
Sep 11, 2023
| @@ -82,6 +85,72 @@ static void SetNanBits(const ArraySpan& arr, uint8_t* out_bitmap, int64_t out_of | |||
| } | |||
| } | |||
|
|
|||
| static void SetSparseUnionLogicalNullBits(const ArraySpan& span, uint8_t* out_bitmap, | |||
There was a problem hiding this comment.
Would it be worth reusing the choose kernel for this case?
| } | ||
|
|
||
| template <typename RunEndCType> | ||
| void SetREELogicalNullBits(const ArraySpan& span, uint8_t* out_bitmap, |
There was a problem hiding this comment.
Here it seems we could trivially create an ree($index_type, bool), then return that directly or decode it using existing utilities
| int64_t out_offset) { | ||
| const auto* dense_union_type = | ||
| ::arrow::internal::checked_cast<const DenseUnionType*>(span.type); | ||
| DCHECK_LE(span.child_data.size(), 128); |
There was a problem hiding this comment.
Someday if we have more dense union utilities the same trick as for sparse unions could be used here
github-actions
bot
added
awaiting changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Currently the is_null kernel always returns all-False for union and run-end-encoded types, since those don't have a top-level validity buffer. Update the kernel to take the logical nulls into account.
Are these changes tested?
Yes, both in Python and C++
Are there any user-facing changes?
Yes, this changes (corrects) the behaviour of the is_null kernel.
Closes #35036
pa.compute.is_null()returns incorrect answer for dense union arrays and segfaults for dense union scalars #34315