Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-37721: [C++] Dependency: bump aws-sdk to 1.11.68 and avoid memory leak #37736

Closed
wants to merge 1 commit into from

Conversation

mapleFU
Copy link
Member

@mapleFU mapleFU commented Sep 15, 2023

Rationale for this change

See #37721

What changes are included in this PR?

Bump aws-sdk version to https://github.com/aws/aws-sdk-cpp/releases/tag/1.11.68

Are these changes tested?

Already have S3 test

Are there any user-facing changes?

no

@mapleFU
Copy link
Member Author

mapleFU commented Sep 15, 2023

cc @kou

@github-actions
Copy link

⚠️ GitHub issue #37721 has been automatically assigned in GitHub to PR creator.

@mapleFU
Copy link
Member Author

mapleFU commented Sep 15, 2023

Oh seems last update has do much more things, should I also upgrade the submodule?

@kou
Copy link
Member

kou commented Sep 15, 2023

The last update: #33808

Oh seems last update has do much more things, should I also upgrade the submodule?

I think so...

And the current error message https://github.com/apache/arrow/actions/runs/6197952334/job/16827490393?pr=37736#step:7:1658 indicates that we also need to change how to build AWS SDK for C++...
If you aren't familiar with CMake, this task may be difficult...

@mapleFU
Copy link
Member Author

mapleFU commented Sep 15, 2023

Sounds interesting, I'll have a try this weekend

@h-vetinari
Copy link
Contributor

What's special about 1.11.68? Upstream is at 1.11.168 (note the extra "1"; it's 100 patch versions further), while conda-forge is now at 1.11.156 (also being synced back here in #37624)

@mapleFU
Copy link
Member Author

mapleFU commented Sep 21, 2023

https://github.com/apache/arrow/blob/main/ci/conda_env_cpp.txt#L18C1-L18C20

Here it uses 1.11.68 @h-vetinari

I find aws-sdk release it version very frequently, and I don't know if it's better to use a "stable" release rather than a "latest" release. Do you have some advices?

@h-vetinari
Copy link
Contributor

I find aws-sdk release it version very frequently, and I don't know if it's better to use a "stable" release rather than a "latest" release. Do you have some advices?

They're all equally good / bad / stable / unstable. The very likely only reason your environment got stuck on 1.11.68, is that this was the newest version in conda-forge for a while, because we were exactly figuring out how to deal with the flood of versions. We've now solved this, and will be rebuilding once every ~20 versions (at random! there's really no reason to choose one or the other).

@mapleFU
Copy link
Member Author

mapleFU commented Sep 21, 2023

Thanks for your advice, let me have a try

@pitrou pitrou requested a review from kou September 26, 2023 14:24
@mapleFU
Copy link
Member Author

mapleFU commented Oct 3, 2023

I catch a cold in september and now I don't have enough bandwidth to get familiar with CMake and work on this before 14.0 release, so I'll first close and give up this issue, sorry for occipied the time and do nothing. orz

@mapleFU mapleFU closed this Oct 3, 2023
@kou
Copy link
Member

kou commented Oct 3, 2023

No problem. :-)
Thanks for working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[C++] Memory leak in s3 filesystem
3 participants