-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-36994: [Java] Use JDK 21 in CI #38219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
|
Eclipse temurin released JDK 21 docker images, but the maven integration is not available yet. https://hub.docker.com/_/maven |
e808e2c to
798549e
Compare
|
@github-actions crossbow submit java |
|
Revision: ece3900 Submitted crossbow builds: ursacomputing/crossbow @ actions-1249464d08 |
raulcd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a minor comment but I am happy to merge as is and (possibly) update the release verification script, if necessary, on a separate PR
| </pluginManagement> | ||
| </build> | ||
|
|
||
| <profiles> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this change mean we can potentially remove this pinned version for release verification?
https://github.com/apache/arrow/blob/main/dev/release/verify-release-candidate.sh#L569
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so! I'll try it out
|
@github-actions crossbow submit java |
|
Revision: e3e1e58 Submitted crossbow builds: ursacomputing/crossbow @ actions-9c56b511e1 |
|
@github-actions crossbow submit verify-rc-source-java-macos-amd64 |
|
Revision: e3e1e58 Submitted crossbow builds: ursacomputing/crossbow @ actions-24a7b025d6
|
raulcd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
### Rationale for this change Verify JDK 21 in CI in time for the Arrow v14 release. ### What changes are included in this PR? * Bump latest Java version from 20 -> 21 in CI ### Are these changes tested? Yes, via CI. ### Are there any user-facing changes? No. * Closes: #36994 Authored-by: Dane Pitkin <dane@voltrondata.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 39298fe. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them. |
### Rationale for this change Verify JDK 21 in CI in time for the Arrow v14 release. ### What changes are included in this PR? * Bump latest Java version from 20 -> 21 in CI ### Are these changes tested? Yes, via CI. ### Are there any user-facing changes? No. * Closes: apache#36994 Authored-by: Dane Pitkin <dane@voltrondata.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
### Rationale for this change Verify JDK 21 in CI in time for the Arrow v14 release. ### What changes are included in this PR? * Bump latest Java version from 20 -> 21 in CI ### Are these changes tested? Yes, via CI. ### Are there any user-facing changes? No. * Closes: apache#36994 Authored-by: Dane Pitkin <dane@voltrondata.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
### Rationale for this change Verify JDK 21 in CI in time for the Arrow v14 release. ### What changes are included in this PR? * Bump latest Java version from 20 -> 21 in CI ### Are these changes tested? Yes, via CI. ### Are there any user-facing changes? No. * Closes: apache#36994 Authored-by: Dane Pitkin <dane@voltrondata.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
Rationale for this change
Verify JDK 21 in CI in time for the Arrow v14 release.
What changes are included in this PR?
Are these changes tested?
Yes, via CI.
Are there any user-facing changes?
No.