Skip to content

Conversation

@danepitkin
Copy link
Member

@danepitkin danepitkin commented Oct 11, 2023

Rationale for this change

Verify JDK 21 in CI in time for the Arrow v14 release.

What changes are included in this PR?

  • Bump latest Java version from 20 -> 21 in CI

Are these changes tested?

Yes, via CI.

Are there any user-facing changes?

No.

@github-actions
Copy link

⚠️ GitHub issue #36994 has been automatically assigned in GitHub to PR creator.

@danepitkin
Copy link
Member Author

Eclipse temurin released JDK 21 docker images, but the maven integration is not available yet. https://hub.docker.com/_/maven

@danepitkin danepitkin marked this pull request as draft October 11, 2023 19:51
@danepitkin danepitkin marked this pull request as ready for review October 14, 2023 15:25
@danepitkin
Copy link
Member Author

@github-actions crossbow submit java

@github-actions
Copy link

Revision: ece3900

Submitted crossbow builds: ursacomputing/crossbow @ actions-1249464d08

Task Status
java-jars Github Actions
verify-rc-source-java-linux-almalinux-8-amd64 Github Actions
verify-rc-source-java-linux-conda-latest-amd64 Github Actions
verify-rc-source-java-linux-ubuntu-20.04-amd64 Github Actions
verify-rc-source-java-linux-ubuntu-22.04-amd64 Github Actions
verify-rc-source-java-macos-amd64 Github Actions

Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a minor comment but I am happy to merge as is and (possibly) update the release verification script, if necessary, on a separate PR

</pluginManagement>
</build>

<profiles>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this change mean we can potentially remove this pinned version for release verification?
https://github.com/apache/arrow/blob/main/dev/release/verify-release-candidate.sh#L569

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so! I'll try it out

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Oct 16, 2023
@danepitkin
Copy link
Member Author

@github-actions crossbow submit java

@github-actions
Copy link

Revision: e3e1e58

Submitted crossbow builds: ursacomputing/crossbow @ actions-9c56b511e1

Task Status
java-jars Github Actions
verify-rc-source-java-linux-almalinux-8-amd64 Github Actions
verify-rc-source-java-linux-conda-latest-amd64 Github Actions
verify-rc-source-java-linux-ubuntu-20.04-amd64 Github Actions
verify-rc-source-java-linux-ubuntu-22.04-amd64 Github Actions
verify-rc-source-java-macos-amd64 Github Actions

@danepitkin
Copy link
Member Author

@github-actions crossbow submit verify-rc-source-java-macos-amd64

@github-actions
Copy link

Revision: e3e1e58

Submitted crossbow builds: ursacomputing/crossbow @ actions-24a7b025d6

Task Status
verify-rc-source-java-macos-amd64 Github Actions

Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@raulcd raulcd merged commit 39298fe into apache:main Oct 17, 2023
@raulcd raulcd removed the awaiting merge Awaiting merge label Oct 17, 2023
raulcd pushed a commit that referenced this pull request Oct 17, 2023
### Rationale for this change

Verify JDK 21 in CI in time for the Arrow v14 release.

### What changes are included in this PR?

* Bump latest Java version from 20 -> 21 in CI

### Are these changes tested?

Yes, via CI.

### Are there any user-facing changes?

No.
* Closes: #36994

Authored-by: Dane Pitkin <dane@voltrondata.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
@github-actions github-actions bot added the awaiting merge Awaiting merge label Oct 17, 2023
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 39298fe.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them.

loicalleyne pushed a commit to loicalleyne/arrow that referenced this pull request Nov 13, 2023
### Rationale for this change

Verify JDK 21 in CI in time for the Arrow v14 release.

### What changes are included in this PR?

* Bump latest Java version from 20 -> 21 in CI

### Are these changes tested?

Yes, via CI.

### Are there any user-facing changes?

No.
* Closes: apache#36994

Authored-by: Dane Pitkin <dane@voltrondata.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
### Rationale for this change

Verify JDK 21 in CI in time for the Arrow v14 release.

### What changes are included in this PR?

* Bump latest Java version from 20 -> 21 in CI

### Are these changes tested?

Yes, via CI.

### Are there any user-facing changes?

No.
* Closes: apache#36994

Authored-by: Dane Pitkin <dane@voltrondata.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
pribor pushed a commit to GlobalWebIndex/arrow that referenced this pull request Oct 24, 2025
### Rationale for this change

Verify JDK 21 in CI in time for the Arrow v14 release.

### What changes are included in this PR?

* Bump latest Java version from 20 -> 21 in CI

### Are these changes tested?

Yes, via CI.

### Are there any user-facing changes?

No.
* Closes: apache#36994

Authored-by: Dane Pitkin <dane@voltrondata.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Java][CI] Enable JDK 21

2 participants