MINOR: [GLib][Docs] Specify downloaded archive name explicitly #38497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: GLib
Component: Documentation
awaiting review
kou
changed the title
kou
changed the title
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 7ef517e. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
|
Thanks for clearly renaming the pull request title and description. |
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…e#38497) ### Rationale for this change Unable to extract on the [arrow/c_glib/README.md](https://github.com/apache/arrow/blob/848725f31b2633a35a0389e4ffb96e1c14bc8e26/c_glib/README.md?plain=1#L70-L71) because the downloaded file name is `closer.lua?action=download&filename=arrow%2Farrow-12.0.0%2Fapache-arrow-12.0.0.tar.gz` not `apache-arrow-12.0.0.tar.gz`. ### What changes are included in this PR? Specify the downloaded file name explicitly. Authored-by: Tsutomu Katsube <tsuto.katsube@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…e#38497) ### Rationale for this change Unable to extract on the [arrow/c_glib/README.md](https://github.com/apache/arrow/blob/848725f31b2633a35a0389e4ffb96e1c14bc8e26/c_glib/README.md?plain=1#L70-L71) because the downloaded file name is `closer.lua?action=download&filename=arrow%2Farrow-12.0.0%2Fapache-arrow-12.0.0.tar.gz` not `apache-arrow-12.0.0.tar.gz`. ### What changes are included in this PR? Specify the downloaded file name explicitly. Authored-by: Tsutomu Katsube <tsuto.katsube@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Unable to extract on the arrow/c_glib/README.md because the downloaded file name is
closer.lua?action=download&filename=arrow%2Farrow-12.0.0%2Fapache-arrow-12.0.0.tar.gznotapache-arrow-12.0.0.tar.gz.What changes are included in this PR?
Specify the downloaded file name explicitly.