Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-38528: [Python][Compute] Describe strptime format semantics #38665

Merged
merged 2 commits into from
Nov 13, 2023
Merged

GH-38528: [Python][Compute] Describe strptime format semantics #38665

merged 2 commits into from
Nov 13, 2023

Conversation

no23reason
Copy link
Contributor

@no23reason no23reason commented Nov 10, 2023 •
edited by github-actions bot
Loading

Rationale for this change

To prevent possible confusion with the compute strptime function, we now explicitly mention that the C/C++ semantics are followed.

What changes are included in this PR?

The documentation of the format parameter of the strptime function is expanded.

Are these changes tested?

N/A documentation change only.

Are there any user-facing changes?

Just the documentation.

@no23reason
apacheGH-38528: [Python][Compute] Describe strptime format semantics
4dfa21a 
To prevent possible confusion with the compute strptime function, we now explicitly mention that the C/C++ semantics are followed.
@no23reason
Copy link
Contributor Author

@github-actions crossbow submit preview-docs

@github-actions GitHub Actions
Copy link

⚠️ GitHub issue #38528 has been automatically assigned in GitHub to PR creator.

@github-actions GitHub Actions
Copy link 

Only contributors can submit requests to this bot. Please ask someone from the community for help with getting the first commit in.
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/6823944241

@no23reason no23reason mentioned this pull request Nov 10, 2023
Closed
@rok
Copy link
Member

rok commented Nov 10, 2023

@github-actions crossbow submit preview-docs

@github-actions GitHub Actions
Copy link

Revision: 4dfa21a

Submitted crossbow builds: ursacomputing/crossbow @ actions-e79d534cc7

Task Status
preview-docs Github Actions

@rok
Copy link
Member

rok commented Nov 10, 2023

@github-actions crossbow submit preview-docs

@rok
Copy link
Member

rok commented Nov 10, 2023

Once docs are built they will be viewable at http://crossbow.voltrondata.com/pr_docs/38665

@github-actions GitHub Actions
Copy link

Revision: 4dfa21a

Submitted crossbow builds: ursacomputing/crossbow @ actions-09574f30f3

Task Status
preview-docs Github Actions

@rok
Copy link
Member

rok commented Nov 13, 2023

I got this building locally with some effort - I used ninja-debug-python cmake preset and have the following exports:

export PYARROW_WITH_PARQUET=1
export PYARROW_WITH_DATASET=1
export PYARROW_WITH_SUBSTRAIT=1
export PYARROW_WITH_ACERO=1
export PYARROW_WITH_COMPUTE=1

Result:
Screenshot from 2023-11-13 02-30-10

rok
rok reviewed Nov 13, 2023
View reviewed changes
python/pyarrow/_compute.pyx Outdated Show resolved Hide resolved
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Nov 13, 2023
@rok
Copy link
Member

rok commented Nov 13, 2023 •
edited
Loading

Revision: 4dfa21a

Submitted crossbow builds: ursacomputing/crossbow @ actions-e79d534cc7

Task Status
preview-docs Github Actions

@assignUser it seems that AWS CLI binary is not found, is this known or shall I open an issue?

/home/runner/work/_temp/760ee02b-fed6-4047-ace0-49260f3fa628.sh: line 1: aws: command not found

@assignUser
Copy link
Member

assignUser commented Nov 13, 2023 •
edited
Loading

Hm this is happening outside of the docker container so perhaps the runner image changed and removed it? It's news to me

@no23reason @rok
apacheGH-38528: [Python][Compute] Improve strptime format description
a301c7c 
Splits a long sentence, makes the language more directive.

Co-authored-by: Rok Mihevc <rok@mihevc.org>
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Nov 13, 2023
@no23reason
Copy link
Contributor Author

@rok thank you for the preview and the suggestion! I applied it, I think it is now ready for final review :)

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels Nov 13, 2023
@rok rok merged commit 79c72a6 into apache:main Nov 13, 2023
12 checks passed
@rok rok removed the awaiting merge Awaiting merge label Nov 13, 2023
@rok
Copy link
Member

rok commented Nov 13, 2023

Thanks for doing this @no23reason !

@no23reason
Copy link
Contributor Author

Thank you for your very patient support @rok!

@conbench-apache-arrow conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 79c72a6.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

loicalleyne pushed a commit to loicalleyne/arrow that referenced this pull request Nov 13, 2023
@no23reason @rok @loicalleyne
apacheGH-38528: [Python][Compute] Describe strptime format semantics (a…
4643e22 
…pache#38665)

### Rationale for this change

To prevent possible confusion with the compute strptime function, we now explicitly mention that the C/C++ semantics are followed.

### What changes are included in this PR?

The documentation of the `format` parameter of the `strptime` function is expanded.

### Are these changes tested?

N/A documentation change only.

### Are there any user-facing changes?

Just the documentation.
* Closes: apache#38528

Lead-authored-by: Dan Homola <dan.homola@hotmail.cz>
Co-authored-by: Dan Homola <dan.homola@gooddata.com>
Co-authored-by: Rok Mihevc <rok@mihevc.org>
Signed-off-by: Rok Mihevc <rok@mihevc.org>
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
@no23reason @rok @dgreiss
apacheGH-38528: [Python][Compute] Describe strptime format semantics (a…
aca4893 
…pache#38665)

### Rationale for this change

To prevent possible confusion with the compute strptime function, we now explicitly mention that the C/C++ semantics are followed.

### What changes are included in this PR?

The documentation of the `format` parameter of the `strptime` function is expanded.

### Are these changes tested?

N/A documentation change only.

### Are there any user-facing changes?

Just the documentation.
* Closes: apache#38528

Lead-authored-by: Dan Homola <dan.homola@hotmail.cz>
Co-authored-by: Dan Homola <dan.homola@gooddata.com>
Co-authored-by: Rok Mihevc <rok@mihevc.org>
Signed-off-by: Rok Mihevc <rok@mihevc.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rok rok rok approved these changes

Assignees
No one assigned
Labels
Component: Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Python][Compute] Make pyarrow.compute.strptime %Y handling consistent with time.strptime
3 participants
@no23reason @rok @assignUser