Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-39119: [C++] Refactor the Azure FS tests and filesystem class instantiation #39207

Merged
merged 26 commits into from
Dec 14, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
c8a0d8b
Introduce BodyTextView() and IsContainerNotFound()
felipecrv Dec 8, 2023
b0ba6ae
Explain better what ADLS Gen is and how it interacts with Blobs Storage
felipecrv Dec 8, 2023
2a13efc
Change AzureOptions towards how it should work
felipecrv Dec 9, 2023
fe9a923
Use namespace aliases to shorten the references to Azure:: types
felipecrv Dec 9, 2023
aa48525
Refactor the Azure FS tests
felipecrv Dec 12, 2023
0a8bf1a
azurefs_test.cc: Use TYPED_TEST_SUITE to generate tests for all envs
felipecrv Dec 13, 2023
79145a5
Make PreexistingData setup explicit
felipecrv Dec 13, 2023
551f11c
fixup! Refactor the Azure FS tests
felipecrv Dec 13, 2023
907c2f7
Explain all the factories for the Azure envs
felipecrv Dec 13, 2023
0e827a4
Use instead of size_t
felipecrv Dec 13, 2023
ffea4e2
Remove bool from enum class AzureBackend
felipecrv Dec 13, 2023
502997a
Fail if only one of the environment variables is set
felipecrv Dec 13, 2023
e37a7b4
Make PreexistingData::ContainerPath take an argument and use it inste…
felipecrv Dec 13, 2023
0a31158
Simplify condition
felipecrv Dec 13, 2023
dd9868f
Use ASSERT_RAISES instead of ASSERT_NOT_OK
felipecrv Dec 13, 2023
5aab621
Remove redundant std::move
felipecrv Dec 13, 2023
6b4993d
Make AzureOptions factories return a Result<>
felipecrv Dec 13, 2023
7fef9f3
Rename all the tests to have Test- in the beginning
felipecrv Dec 13, 2023
272aa82
Rename hierarchical_namespace_ to hns_detector_
felipecrv Dec 13, 2023
5e47e2b
Fix lint error
felipecrv Dec 14, 2023
bdf8cb3
azurefs.cc: Alias the Azure::Core::HTTP namespace as well
felipecrv Dec 14, 2023
e45d94d
Move ExceptionToStatus to azurefs.cc
felipecrv Dec 14, 2023
7d2d789
Prevent half-constructed state and remove AzureFileSystem::Init()
felipecrv Dec 14, 2023
ccd1f1d
Remove redundant virtual destructors
felipecrv Dec 14, 2023
3b3c329
typo
felipecrv Dec 14, 2023
4f45c67
Correct ordering of fields
felipecrv Dec 14, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading