GH-39006: [Python] Extract libparquet requirements out of libarrow_python.so to new libarrow_python_parquet_encryption.so #39316

raulcd · 2023-12-20T12:13:23Z

Rationale for this change

If I build pyarrow with everything and then I remove some of the Arrow CPP .so in order to have a minimal build I can't import pyarrow because it requires libarrow and libparquet. This is relevant in order to have a minimal build for Conda. Please see the related issue for more information.

What changes are included in this PR?

Move libarrow parquet encryption for pyarrow to its own shared object.

Are these changes tested?

I will run extensive CI with extra python archery tests.

Are there any user-facing changes?

No, and yes :) There will be a new .so on pyarrow but shouldn't be relevant in my opinion.

Closes: [Python] Minimal pyarrow installation should not require libparquet #39006

github-actions · 2023-12-20T12:13:52Z

⚠️ GitHub issue #39006 has been automatically assigned in GitHub to PR creator.

raulcd · 2023-12-20T12:15:48Z

@github-actions crossbow submit -g python

jorisvandenbossche · 2023-12-20T12:26:24Z

Thanks! This looks good to me, but I am not a CMake expert ;)
I assume you tested this locally that it now works to have a minimal pyarrow without parquet? Do we want to a nightly build that verifies this?

jorisvandenbossche · 2023-12-20T12:32:08Z

Do we want to a nightly build that verifies this?

Although we have the example-python-minimal-build-* builds, and according to the test logs (eg https://github.com/ursacomputing/crossbow/actions/runs/7269207616/job/19806469446#step:3:4711), they do skip the parquet tests.

So why was this build not failing? (building the C++ doesn't seem to enable Parquet in eg https://github.com/apache/arrow/blob/main/python/examples/minimal_build/build_venv.sh)

AlenkaF · 2023-12-20T12:50:18Z

If I would move parquet encryption to a separate .so I would do the same so nothing to comment.

Regarding the minimal build that wasn't failing:
I was also a bit confused when I tried building locally on main. I built Arrow C++ without parquet but with datasets and parquet encryption then I build PyArrow without parquet but with dataset and parquet encryption enabled and it worked, I was able to install pyarrow. Thought I didn't understand the issue, maybe I still do not though =)

jorisvandenbossche · 2023-12-20T13:19:52Z

The Windows failure seems related

raulcd · 2023-12-20T13:35:51Z

Thanks, I am testing a little further locally to validate the use case I am trying to fix works. I'll investigate the Windows failure.

@AlenkaF I am also confused, my expectation if Arrow CPP is built without parquet and there's no libparquet.so file that:
set(PYARROW_CPP_ENCRYPTION_LINK_LIBS Parquet::parquet_shared) would fail to build on pyarrow. I'll try to investigate that further too.

raulcd · 2023-12-20T13:48:37Z

ok, the fix seems to work for the use case I am trying to solve.

I've built pyarrow with "everything":

$ python
Python 3.10.12 (main, Nov 20 2023, 15:14:05) [GCC 11.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import pyarrow
>>> import pyarrow.parquet
>>>

after I do the following:

$ cd ../../dist/
$ find . -iname libparquet.so
./lib/libparquet.so
$ mkdir raul
$ mv lib/libparquet.* raul/
$ find . -iname libparquet.so
./raul/libparquet.so

I get:

$ python
Python 3.10.12 (main, Nov 20 2023, 15:14:05) [GCC 11.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import pyarrow
>>> import pyarrow.parquet
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/raulcd/code/arrow/python/pyarrow/parquet/__init__.py", line 20, in <module>
    from .core import *
  File "/home/raulcd/code/arrow/python/pyarrow/parquet/core.py", line 40, in <module>
    raise ImportError(
ImportError: The pyarrow installation is not built with support for the Parquet file format (libparquet.so.1500: cannot open shared object file: No such file or directory)

as expected. Without the change once I remove libparquet I can't import pyarrow:

$ python
Python 3.10.12 (main, Nov 20 2023, 15:14:05) [GCC 11.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import pyarrow
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/raulcd/code/arrow/python/pyarrow/__init__.py", line 65, in <module>
    import pyarrow.lib as _lib
ImportError: libparquet.so.1500: cannot open shared object file: No such file or directory

jorisvandenbossche · 2023-12-20T14:02:12Z

Ah, so the reason it is working in the CI build is because there Parquet is not built at all (also C++ is not built with it, pyarrow is not built with it), and that works fine. But for conda, we actually do build pyarrow with support for Parquet, but then just leave out the parquet so library for the minimal install. And that's the case that was not working.

raulcd · 2023-12-20T17:03:27Z

The sphinx error is also related to the change. I'll have to investigate further that too.

pitrou · 2023-12-20T17:07:45Z

I'm curious, is this all that's needed? How does pyarrow.parquet link against the new libarrow_python_parquet_encryption.so?

raulcd · 2023-12-20T17:17:09Z

I'm curious, is this all that's needed?

Probably not and I am missing something :) I'll keep working on it but I am surprised that no test- jobs failed. I would have expected tests to fail if there was some linking problem.

pitrou · 2023-12-20T17:19:50Z

Ok, I'm testing this PR and I get:

$ python -c "import pyarrow.parquet.encryption"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/home/antoine/arrow/dev/python/pyarrow/parquet/encryption.py", line 19, in <module>
    from pyarrow._parquet_encryption import (CryptoFactory,   # noqa
ImportError: /home/antoine/arrow/dev/python/pyarrow/_parquet_encryption.cpython-310-x86_64-linux-gnu.so: undefined symbol: _ZN5arrow2py7parquet10encryption11PyKmsClientC1EP7_objectNS2_17PyKmsClientVtableE

pitrou · 2023-12-20T17:36:29Z

@github-actions crossbow submit -g python -g wheel

pitrou · 2023-12-20T18:13:00Z

@github-actions crossbow submit wheel-windows-*

pitrou · 2023-12-20T19:30:02Z

The Windows wheel failures look unrelated...

raulcd · 2023-12-20T19:35:36Z

The Windows wheels failures seem to have been failing on the nightly builds for some days.

pitrou · 2023-12-20T19:36:20Z

The Windows wheels failures seem to have been failing on the nightly builds for some days.

Is an issue open for it?

raulcd · 2023-12-20T19:38:23Z

Is an issue open for it?

I don't think so. I was planning to go over all the nightly failures and open issues in the next days in preparation for the release but I haven't had the time yet

python/CMakeLists.txt

kou · 2023-12-21T00:14:25Z

#39333 for Windows wheel build failure.

raulcd · 2023-12-21T09:50:04Z

@github-actions crossbow submit -g python -g wheel

…row_python.so to new libarrow_python_parquet_encryption.so

…rquet_encryption.so

…ARQUET_LINK_LIBS from target_link_libraries

pitrou · 2023-12-21T09:55:08Z

@github-actions crossbow submit -g python -g wheel

pitrou · 2023-12-21T09:55:25Z

I rebased to get the Windows wheel fix.

github-actions · 2023-12-21T09:58:05Z

Revision: 6ee40c9

Submitted crossbow builds: ursacomputing/crossbow @ actions-0f80c7792a

Task	Status
test-conda-python-3.10
test-conda-python-3.10-cython2
test-conda-python-3.10-hdfs-2.9.2
test-conda-python-3.10-hdfs-3.2.1
test-conda-python-3.10-pandas-latest
test-conda-python-3.10-pandas-nightly
test-conda-python-3.10-spark-v3.5.0
test-conda-python-3.10-substrait
test-conda-python-3.11
test-conda-python-3.11-dask-latest
test-conda-python-3.11-dask-upstream_devel
test-conda-python-3.11-hypothesis
test-conda-python-3.11-pandas-upstream_devel
test-conda-python-3.11-spark-master
test-conda-python-3.12
test-conda-python-3.8
test-conda-python-3.8-pandas-1.0
test-conda-python-3.8-spark-v3.5.0
test-conda-python-3.9
test-conda-python-3.9-pandas-latest
test-cuda-python
test-debian-11-python-3
test-fedora-38-python-3
test-ubuntu-20.04-python-3
test-ubuntu-22.04-python-3
wheel-macos-big-sur-cp310-arm64
wheel-macos-big-sur-cp311-arm64
wheel-macos-big-sur-cp312-arm64
wheel-macos-big-sur-cp38-arm64
wheel-macos-big-sur-cp39-arm64
wheel-macos-catalina-cp310-amd64
wheel-macos-catalina-cp311-amd64
wheel-macos-catalina-cp312-amd64
wheel-macos-catalina-cp38-amd64
wheel-macos-catalina-cp39-amd64
wheel-manylinux-2-28-cp310-amd64
wheel-manylinux-2-28-cp310-arm64
wheel-manylinux-2-28-cp311-amd64
wheel-manylinux-2-28-cp311-arm64
wheel-manylinux-2-28-cp312-amd64
wheel-manylinux-2-28-cp312-arm64
wheel-manylinux-2-28-cp38-amd64
wheel-manylinux-2-28-cp38-arm64
wheel-manylinux-2-28-cp39-amd64
wheel-manylinux-2-28-cp39-arm64
wheel-manylinux-2014-cp310-amd64
wheel-manylinux-2014-cp310-arm64
wheel-manylinux-2014-cp311-amd64
wheel-manylinux-2014-cp311-arm64
wheel-manylinux-2014-cp312-amd64
wheel-manylinux-2014-cp312-arm64
wheel-manylinux-2014-cp38-amd64
wheel-manylinux-2014-cp38-arm64
wheel-manylinux-2014-cp39-amd64
wheel-manylinux-2014-cp39-arm64
wheel-windows-cp310-amd64
wheel-windows-cp311-amd64
wheel-windows-cp312-amd64
wheel-windows-cp38-amd64
wheel-windows-cp39-amd64

kou

+1

conbench-apache-arrow · 2023-12-22T18:43:50Z

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 51970e0.

There was 1 benchmark result with an error:

Commit Run on ursa-i9-9960x at 2023-12-22 09:10:58Z
- tpch (R) with engine=arrow, format=native, language=R, memory_map=False, query_id=TPCH-15, scale_factor=10

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

…row_python.so to new libarrow_python_parquet_encryption.so (apache#39316) ### Rationale for this change If I build pyarrow with everything and then I remove some of the Arrow CPP .so in order to have a minimal build I can't import pyarrow because it requires libarrow and libparquet. This is relevant in order to have a minimal build for Conda. Please see the related issue for more information. ### What changes are included in this PR? Move libarrow parquet encryption for pyarrow to its own shared object. ### Are these changes tested? I will run extensive CI with extra python archery tests. ### Are there any user-facing changes? No, and yes :) There will be a new .so on pyarrow but shouldn't be relevant in my opinion. * Closes: apache#39006 Lead-authored-by: Raúl Cumplido <raulcumplido@gmail.com> Co-authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Sutou Kouhei <kou@clear-code.com>

github-actions bot added Component: Python awaiting committer review Awaiting committer review labels Dec 20, 2023

raulcd requested review from jorisvandenbossche, AlenkaF and kou December 20, 2023 12:16

This comment was marked as outdated.

Sign in to view

raulcd requested a review from assignUser as a code owner December 20, 2023 17:25

This comment was marked as outdated.

Sign in to view

kou reviewed Dec 20, 2023

View reviewed changes

python/CMakeLists.txt Outdated Show resolved Hide resolved

python/CMakeLists.txt Outdated Show resolved Hide resolved

github-actions bot removed the awaiting committer review Awaiting committer review label Dec 20, 2023

github-actions bot added the awaiting changes Awaiting changes label Dec 20, 2023

github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Dec 21, 2023

raulcd and others added 6 commits December 21, 2023 10:53

apacheGH-39006: [Python] Extract libparquet requirements out of libar…

80de8f3

…row_python.so to new libarrow_python_parquet_encryption.so

Make sure Parquet encryption is tested where enabled

67625b1

Link the _parquet_encryption extension module with libarrow_python_pa…

007c8f0

…rquet_encryption.so

Try to fix DLL exporting failure on Windows

9969890

Fix lint

bd4fb96

Reuse PARQUET_LINK_LIBS instead of creating new variable and remove P…

6ee40c9

…ARQUET_LINK_LIBS from target_link_libraries

pitrou force-pushed the GH-39006 branch from 4faf42b to 6ee40c9 Compare December 21, 2023 09:53

This comment was marked as outdated.

Sign in to view

pitrou requested a review from kou December 21, 2023 13:05

kou approved these changes Dec 22, 2023

View reviewed changes

kou merged commit 51970e0 into apache:main Dec 22, 2023
13 checks passed

kou removed the awaiting change review Awaiting change review label Dec 22, 2023

github-actions bot added the awaiting merge Awaiting merge label Dec 22, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GH-39006: [Python] Extract libparquet requirements out of libarrow_python.so to new libarrow_python_parquet_encryption.so #39316

GH-39006: [Python] Extract libparquet requirements out of libarrow_python.so to new libarrow_python_parquet_encryption.so #39316

raulcd commented Dec 20, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Dec 20, 2023

raulcd commented Dec 20, 2023

This comment was marked as outdated.

jorisvandenbossche commented Dec 20, 2023

jorisvandenbossche commented Dec 20, 2023

AlenkaF commented Dec 20, 2023

jorisvandenbossche commented Dec 20, 2023

raulcd commented Dec 20, 2023

raulcd commented Dec 20, 2023

jorisvandenbossche commented Dec 20, 2023

raulcd commented Dec 20, 2023

pitrou commented Dec 20, 2023

raulcd commented Dec 20, 2023

pitrou commented Dec 20, 2023

pitrou commented Dec 20, 2023

This comment was marked as outdated.

pitrou commented Dec 20, 2023

This comment was marked as outdated.

pitrou commented Dec 20, 2023

raulcd commented Dec 20, 2023

pitrou commented Dec 20, 2023

raulcd commented Dec 20, 2023

kou commented Dec 21, 2023

raulcd commented Dec 21, 2023

This comment was marked as outdated.

pitrou commented Dec 21, 2023

pitrou commented Dec 21, 2023

github-actions bot commented Dec 21, 2023

kou left a comment

conbench-apache-arrow bot commented Dec 22, 2023

GH-39006: [Python] Extract libparquet requirements out of libarrow_python.so to new libarrow_python_parquet_encryption.so #39316

GH-39006: [Python] Extract libparquet requirements out of libarrow_python.so to new libarrow_python_parquet_encryption.so #39316

Conversation

raulcd commented Dec 20, 2023 • edited by github-actions bot Loading

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

github-actions bot commented Dec 20, 2023

raulcd commented Dec 20, 2023

This comment was marked as outdated.

jorisvandenbossche commented Dec 20, 2023

jorisvandenbossche commented Dec 20, 2023

AlenkaF commented Dec 20, 2023

jorisvandenbossche commented Dec 20, 2023

raulcd commented Dec 20, 2023

raulcd commented Dec 20, 2023

jorisvandenbossche commented Dec 20, 2023

raulcd commented Dec 20, 2023

pitrou commented Dec 20, 2023

raulcd commented Dec 20, 2023

pitrou commented Dec 20, 2023

pitrou commented Dec 20, 2023

This comment was marked as outdated.

pitrou commented Dec 20, 2023

This comment was marked as outdated.

pitrou commented Dec 20, 2023

raulcd commented Dec 20, 2023

pitrou commented Dec 20, 2023

raulcd commented Dec 20, 2023

kou commented Dec 21, 2023

raulcd commented Dec 21, 2023

This comment was marked as outdated.

pitrou commented Dec 21, 2023

pitrou commented Dec 21, 2023

github-actions bot commented Dec 21, 2023

kou left a comment

Choose a reason for hiding this comment

conbench-apache-arrow bot commented Dec 22, 2023

raulcd commented Dec 20, 2023 •

edited by github-actions bot

Loading