GH-39289: [JS] Add types to exports

[domoritz]

• Closes: [JS] TypeScript types don't work with Node ESM #39289

[github-actions]

⚠️ GitHub issue #39289 has been automatically assigned in GitHub to PR creator.

[andrew0]

I ran yarn build && npx @arethetypeswrong/cli --pack targets/apache-arrow, and it gives these errors:

after changing the types to come first:

The masquerading as CJS error will make it so in ESM mode, TypeScript will let you do import arrow from 'apache-arrow', which would be a runtime error since there's no default export, so it really should be import * as arrow from 'apache-arrow'.

[andrew0]

I believe that this should fix the types for all the import scenarios: andrew0@207881a

[domoritz]

Thanks! I made the updates.

[conbench-apache-arrow]

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 17b946c.

There were 2 benchmark results with an error:

• Commit Run on ursa-i9-9960x at 2024-01-06 11:24:47Z
  • file-write (R) with compression=uncompressed, dataset=fanniemae_2016Q4, file_type=parquet, input_type=table, language=R
  • tpch (R) with engine=arrow, format=parquet, language=R, memory_map=False, query_id=TPCH-16, scale_factor=10

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.

[ixxie]

@domoritz thanks for merging this! What does the release timeline look like for this?

[domoritz]

This will be in arrow 15 shortly