Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-39968: [Python][FS][Azure] Minimal Python bindings for
AzureFileSystem
#40021GH-39968: [Python][FS][Azure] Minimal Python bindings for
AzureFileSystem
#40021Changes from all commits
c520a1d
aa0a1b8
ffd1534
3cdbc2e
46d9135
e51af7b
6f6cf33
6321937
dedeea8
f7c650a
995d787
7af5a42
85d9de3
9bb2c1b
4641fc7
9d11166
2b68dff
c5cb74a
d9cf2ea
26a4632
cb0aefd
02a2233
ca97370
744b119
fc0940a
6b83cca
7c84225
b8ae75a
3d7717a
0174285
514c5dd
30fae58
4801933
0bb64bf
7ad9287
20e7a31
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kou should this also change to
enable_tls
like you did in the URI parsing? cc @Tom-NewtonThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I think so. We may want to use
AzureOptions::FromUri()
instead of re-implementing the same logic.@Tom-Newton Could you follow-up this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created the issue for completing the python bindings and referenced this conversation #40572. There is a good chance that I will work on it but I can't say when.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can the Configure methods on AzureOptions optionally do IO? If so, they should probably be called without the GIL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it does any IO. I think the tests actually prove this. These configure the filesystem for connection to a storage account that doesn't exist. If they were doing any IO I think these tests would fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, thanks. I was asking because S3 does, annoyingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the error handling really happens in
AzureOptions::Make(Blob|DataLake)ServiceClient()