GH-40602: [C++] Move mold linker flags to variables #40603
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Move the mold linker flags to the CMake
CMAKE_*_LINKER_FLAGS
variables. This is the more correct place to add them as they will only be used during linking, it would invalidate any [s]ccache less frequently if changing linkers and I think it is more clear/correct.What changes are included in this PR?
Moving the mold linker flags from the
CMAKE_*_FLAGS
toCMAKE_*_LINKER_FLAGS
.Are these changes tested?
Existing tests and validation would cover these changes and the result is essentially the same as before.
Are there any user-facing changes?
No