Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-40026: [C++][FS][Azure] Add support for reading user defined metadata #40671

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

kou
Copy link
Member

@kou kou commented Mar 19, 2024

Rationale for this change

Users may want to set user defined metadata and/or properties such as Content-Type.

What changes are included in this PR?

  • Write user defined metadata.
  • But the following metadata are written as properties:
    • Content-Type
    • Content-Encoding
    • Content-Language
    • Content-Disposition
    • Cache-Control
  • The following metadata is ignored because corresponding properties are auto generated:
    • Content-Hash

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes.

@kou
Copy link
Member Author

kou commented Mar 19, 2024

@Tom-Newton @felipecrv What do you think about this?

Copy link

⚠️ GitHub issue #40670 has been automatically assigned in GitHub to PR creator.

Copy link
Contributor

@Tom-Newton Tom-Newton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🙂

I think there are actually 3 issues that this resolves: #40670, #40026, #40057

@kou kou changed the title GH-40670: [C++][FS][Azure] Add support for reading user defined metadata GH-40026: [C++][FS][Azure] Add support for reading user defined metadata Mar 20, 2024
Copy link

⚠️ GitHub issue #40026 has been automatically assigned in GitHub to PR creator.

@kou
Copy link
Member Author

kou commented Mar 20, 2024

Oh, I didn't notice that this is related to #40057. (I haven't read #40057 carefully, sorry.)

@kou
Copy link
Member Author

kou commented Mar 21, 2024

I'll merge this in a few days if nobody objects this.

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Mar 22, 2024
@kou kou merged commit fa36cde into apache:main Mar 22, 2024
37 of 39 checks passed
@kou kou deleted the cpp-azure-metadata branch March 22, 2024 22:24
@kou kou removed the awaiting merge Awaiting merge label Mar 22, 2024
Copy link

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit fa36cde.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 8 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants