Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-41039: [Python] ListView pandas tests should use np.nan instead of None #41040

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

danepitkin
Copy link
Member

@danepitkin danepitkin commented Apr 5, 2024

Rationale for this change

ListView pandas conversion tests are failing in upstream development branches of pandas/numpy.

What changes are included in this PR?

  • Use np.nan instead of None when comparing with an expected Pandas Series.

Are these changes tested?

Yes, unit tests updated.

Are there any user-facing changes?

No.

@danepitkin
Copy link
Member Author

@github-actions crossbow submit -g python

Copy link

github-actions bot commented Apr 5, 2024

⚠️ GitHub issue #41039 has been automatically assigned in GitHub to PR creator.

Copy link

github-actions bot commented Apr 5, 2024

Revision: 6c1be46

Submitted crossbow builds: ursacomputing/crossbow @ actions-88b36e596b

Task Status
example-python-minimal-build-fedora-conda GitHub Actions
example-python-minimal-build-ubuntu-venv GitHub Actions
test-conda-python-3.10 GitHub Actions
test-conda-python-3.10-cython2 GitHub Actions
test-conda-python-3.10-hdfs-2.9.2 GitHub Actions
test-conda-python-3.10-hdfs-3.2.1 GitHub Actions
test-conda-python-3.10-pandas-latest GitHub Actions
test-conda-python-3.10-pandas-nightly GitHub Actions
test-conda-python-3.10-spark-v3.5.0 GitHub Actions
test-conda-python-3.10-substrait GitHub Actions
test-conda-python-3.11 GitHub Actions
test-conda-python-3.11-dask-latest GitHub Actions
test-conda-python-3.11-dask-upstream_devel GitHub Actions
test-conda-python-3.11-hypothesis GitHub Actions
test-conda-python-3.11-pandas-upstream_devel GitHub Actions
test-conda-python-3.11-spark-master GitHub Actions
test-conda-python-3.12 GitHub Actions
test-conda-python-3.8 GitHub Actions
test-conda-python-3.8-pandas-1.0 GitHub Actions
test-conda-python-3.8-spark-v3.5.0 GitHub Actions
test-conda-python-3.9 GitHub Actions
test-conda-python-3.9-pandas-latest GitHub Actions
test-cuda-python GitHub Actions
test-debian-12-python-3-amd64 Azure
test-debian-12-python-3-i386 GitHub Actions
test-fedora-39-python-3 Azure
test-ubuntu-20.04-python-3 Azure
test-ubuntu-22.04-python-3 GitHub Actions

@danepitkin danepitkin added this to the 16.0.0 milestone Apr 5, 2024
Copy link
Member

@AlenkaF AlenkaF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1.

Opened an issue for the failing build connected to #40976: #41043

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Apr 5, 2024
@AlenkaF AlenkaF merged commit bf3c1b9 into apache:main Apr 5, 2024
12 checks passed
@AlenkaF AlenkaF removed the awaiting committer review Awaiting committer review label Apr 5, 2024
Copy link

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit bf3c1b9.

There was 1 benchmark result indicating a performance regression:

The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.

tolleybot pushed a commit to tmct/arrow that referenced this pull request May 2, 2024
…ead of None (apache#41040)

### Rationale for this change

ListView pandas conversion tests are failing in upstream development branches of pandas/numpy.

### What changes are included in this PR?

* Use np.nan instead of None when comparing with an expected Pandas Series.

### Are these changes tested?

Yes, unit tests updated.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#41039

Authored-by: Dane Pitkin <dane@voltrondata.com>
Signed-off-by: AlenkaF <frim.alenka@gmail.com>
vibhatha pushed a commit to vibhatha/arrow that referenced this pull request May 25, 2024
…ead of None (apache#41040)

### Rationale for this change

ListView pandas conversion tests are failing in upstream development branches of pandas/numpy.

### What changes are included in this PR?

* Use np.nan instead of None when comparing with an expected Pandas Series.

### Are these changes tested?

Yes, unit tests updated.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#41039

Authored-by: Dane Pitkin <dane@voltrondata.com>
Signed-off-by: AlenkaF <frim.alenka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants